[Validator] Fix translation of AtLeastOneOf constraint message #49484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37e840a to
a21eb9d
Compare
|
Can't we have a test with dummy translations in any locale? |
|
I'll have a look at it 👍 |
a21eb9d to
c45760a
Compare
|
The test has been added with a dummy translator 👍 |
|
|
||
| public function trans(?string $id, array $parameters = [], string $domain = null, string $locale = null): string | ||
| { | ||
| if ($id === 'This value should satisfy at least one of the following constraints:') { |
There was a problem hiding this comment.
let's add another case to also translate "This value should be null."?
There was a problem hiding this comment.
This should be it! Also renamed the test case to be more relevant 🙂
c45760a to
2b1fa28
Compare
2b1fa28 to
a687c9a
Compare
|
Thank you @alexandre-daubois. |
symfony-splitter
pushed a commit
to symfony/validator
that referenced
this pull request
Feb 22, 2023
…sage (alexandre-daubois) This PR was merged into the 5.4 branch. Discussion ---------- [Validator] Fix translation of AtLeastOneOf constraint message | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #41317 | License | MIT | Doc PR | _NA_ New try after Nicolas' hint on symfony/symfony#41325. This is a much simpler solution using execution context to get the base message of the constraint translated. ~I tried to create the relevant test case, but other locales doesn't seem to be available in validators test cases.~ I'm having a look at a test case in a dummy locale after symfony/symfony#49484 (comment) When using another locale, the base message of the constraint is actually translated now: <img width="1238" alt="image" src="https://user-images.githubusercontent.com/2144837/220455120-c17e7ac6-81c5-4dd0-a2fc-b100a6a00688.png"> Commits ------- a687c9a2a0 [Validator] Fix translation of AtLeastOneOf constraint message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New try after Nicolas' hint on #41325.
This is a much simpler solution using execution context to get the base message of the constraint translated.
I tried to create the relevant test case, but other locales doesn't seem to be available in validators test cases.I'm having a look at a test case in a dummy locale after #49484 (comment)When using another locale, the base message of the constraint is actually translated now: