[Validator] Fix translation of AtLeastOneOf constraint message
#41325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I think @przemyslaw-bogusz has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
9bacb1b to
ee02a6d
Compare
ee02a6d to
044f223
Compare
AtLeastOneOf constraint message
OskarStark
reviewed
Aug 1, 2021
044f223 to
a08c00b
Compare
fabpot
requested changes
Oct 30, 2021
| @@ -26,7 +26,7 @@ class AtLeastOneOf extends Composite | ||
| ]; | ||
|
|
||
| public $constraints = []; | ||
| public $message = 'This value should satisfy at least one of the following constraints:'; | ||
| public $message = 'This value should satisfy at least one of the following constraints: {{ child_messages }}'; |
There was a problem hiding this comment.
As of today, translations are the same in all maintained branches, which simplifies things a lot. That would break this pattern as this message would be different depending on the version. I would love to find another way to fix this issue.
There was a problem hiding this comment.
Alright, thank you for your feedback. I'll try to get back with another solution! 👍
There was a problem hiding this comment.
can't we concatenate the other messages after translating the current message?
that would allow not changing the translation tables
There was a problem hiding this comment.
Oh I forgot about this one. I'll have a look at it soon and give it another try with your additional info!
a08c00b to
38b1aef
Compare
|
I ran into this same problem today. Is there anything I can do to help? |
|
Closed in favor of #49484 |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 22, 2023
…sage (alexandre-daubois) This PR was merged into the 5.4 branch. Discussion ---------- [Validator] Fix translation of AtLeastOneOf constraint message | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #41317 | License | MIT | Doc PR | _NA_ New try after Nicolas' hint on #41325. This is a much simpler solution using execution context to get the base message of the constraint translated. ~I tried to create the relevant test case, but other locales doesn't seem to be available in validators test cases.~ I'm having a look at a test case in a dummy locale after #49484 (comment) When using another locale, the base message of the constraint is actually translated now: <img width="1238" alt="image" src="https://user-images.githubusercontent.com/2144837/220455120-c17e7ac6-81c5-4dd0-a2fc-b100a6a00688.png"> Commits ------- a687c9a [Validator] Fix translation of AtLeastOneOf constraint message
symfony-splitter
pushed a commit
to symfony/validator
that referenced
this pull request
Feb 22, 2023
…sage (alexandre-daubois) This PR was merged into the 5.4 branch. Discussion ---------- [Validator] Fix translation of AtLeastOneOf constraint message | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #41317 | License | MIT | Doc PR | _NA_ New try after Nicolas' hint on symfony/symfony#41325. This is a much simpler solution using execution context to get the base message of the constraint translated. ~I tried to create the relevant test case, but other locales doesn't seem to be available in validators test cases.~ I'm having a look at a test case in a dummy locale after symfony/symfony#49484 (comment) When using another locale, the base message of the constraint is actually translated now: <img width="1238" alt="image" src="https://user-images.githubusercontent.com/2144837/220455120-c17e7ac6-81c5-4dd0-a2fc-b100a6a00688.png"> Commits ------- a687c9a2a0 [Validator] Fix translation of AtLeastOneOf constraint message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.