[Intl] Generate all emoji short name returned by slack api #49147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, can you update the generated files in the same PR please? |
stof
reviewed
Jan 30, 2023
|
I suggest building a new file flag-emoji.php, to convert country codes to flags. This new feature could enhance the Intl component by adding a convenient method, such as Countries::getFlag('GB'), which would return 🇬🇧. |
|
@adnen-chouibi that feature does not depend on building a map. See https://github.com/thekelvinliu/country-code-emoji for the JS implementation of such a feature, which relies only on the knowledge of how emoji flags are encoded. |
b582e15 to
86742ce
Compare
|
Thank you @adnen-chouibi. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been utilizing the slack-emoji helper to convert country codes to flag emojis. I propose to standardize all flags by using the format :flag-countryCode: for all flags, or maybe create another helper especially for flags. Additionally, I suggest incorporating all emojis returned in the 'short_names' array, rather than relying solely on the 'short_name' value. I have improved the file naming process by generating the file name in the builder, rather than in the 'saveRules' method.