Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Intl] Update slack-emoji.php #49145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

adnen-chouibi
Copy link
Contributor

@adnen-chouibi adnen-chouibi commented Jan 29, 2023

Q A
Branch? 6.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets no
License MIT
Doc PR no

Personally, I use this file to transform country code to flag, I propose to use the same structure for all flags :flag-countryCode: , and to cover also all flags emoji

Personally, I use this file to transform country code to flag, I propose to use the same structure for all flags :flag-countryCode:  , and to cover also all flags emoji
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.2" but it seems your PR description refers to branch "6.2 for bug fixes".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@derrabus derrabus added the Intl label Jan 29, 2023
@carsonbot carsonbot changed the title Update slack-emoji.php [Intl] Update slack-emoji.php Jan 29, 2023
@nicolas-grekas
Copy link
Member

This file is built by the Resources/emoji/build.php file in the component. Can you please update it so that the next time we run the script, we don't loose your changes?

@adnen-chouibi
Copy link
Contributor Author

@OskarStark #49147

@adnen-chouibi adnen-chouibi deleted the patch-1 branch January 30, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.