[WebProfilerBundle] Minor tweaks in profiler redesign #48186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Nov 10, 2022
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/settings.html.twig
Outdated
Show resolved
Hide resolved
stof
reviewed
Nov 10, 2022
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/settings.html.twig
Show resolved
Hide resolved
fabpot
approved these changes
Nov 11, 2022
2edd487 to
2b13d14
Compare
|
Thank you @javiereguiluz. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR is to fix some design issues in the Exception panel of the Symfony Profiler. Sadly, after the #47148 redesign, I couldn't find the time to update the Exception page design. I'll do that in Symfony 6.3, but let's at least fix these minor issues in the current design.
Apart from that, this PR contains some minor tweaks to the design (based on my own usage of the new design and comments shared by the community).
BEFORE Settings options were separated:
AFTER now we group the related options:
The other change is about "tabs". I wasn't 100% happy with the current design which shows a shadow for the active system:
So, yesterday I saw that GitHub introduced a new way of exploring code. It's not public yet, but here's a screenshot of it (with the arrow pointing at their new tab design):
And a short video of new tabs in action:
new-tabs-in-action.mp4
I think they look great, and their flatter design matches our design well. So I propose to get inspiration from them. This is how our tabs look now after this PR:
In action:
And in dark mode: