[Security] Fix AbstractFormLoginAuthenticator return types #47578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Sep 18, 2022
fabpot
approved these changes
Sep 23, 2022
Children of AbstractFormLoginAuthenticator should be allowed to return a `Response` instead of being required to return a `RedirectResponse`. This change matches the return types in the newer AbstractLoginFormAuthenticator.
4f823a8 to
3882065
Compare
|
Thank you @AndrolGenhald. |
This was referenced Sep 30, 2022
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Children of AbstractFormLoginAuthenticator should be allowed to return a
Responseinstead of being required to return aRedirectResponse. This change matches the return types in the newerAbstractLoginFormAuthenticator.Not sure if tests are needed for this, but if they're desired I could use a bit of direction on how to go about it, since it's really only an issue for static analysis.