Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 9fd0eef

Browse filesBrowse files
committed
bug #47578 [Security] Fix AbstractFormLoginAuthenticator return types (AndrolGenhald)
This PR was submitted for the 5.4 branch but it was merged into the 4.4 branch instead. Discussion ---------- [Security] Fix AbstractFormLoginAuthenticator return types | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #47571 | License | MIT | Doc PR | NA Children of AbstractFormLoginAuthenticator should be allowed to return a `Response` instead of being required to return a `RedirectResponse`. This change matches the return types in the newer `AbstractLoginFormAuthenticator`. Not sure if tests are needed for this, but if they're desired I could use a bit of direction on how to go about it, since it's really only an issue for static analysis. Commits ------- 3882065 Fix AbstractFormLoginAuthenticator return types (fixes #47571).
2 parents 50722b8 + 3882065 commit 9fd0eef
Copy full SHA for 9fd0eef

File tree

1 file changed

+3
-2
lines changed
Filter options

1 file changed

+3
-2
lines changed

‎src/Symfony/Component/Security/Guard/Authenticator/AbstractFormLoginAuthenticator.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Security/Guard/Authenticator/AbstractFormLoginAuthenticator.php
+3-2Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313

1414
use Symfony\Component\HttpFoundation\RedirectResponse;
1515
use Symfony\Component\HttpFoundation\Request;
16+
use Symfony\Component\HttpFoundation\Response;
1617
use Symfony\Component\Security\Core\Exception\AuthenticationException;
1718
use Symfony\Component\Security\Core\Security;
1819
use Symfony\Component\Security\Guard\AbstractGuardAuthenticator;
@@ -34,7 +35,7 @@ abstract protected function getLoginUrl();
3435
/**
3536
* Override to change what happens after a bad username/password is submitted.
3637
*
37-
* @return RedirectResponse
38+
* @return Response
3839
*/
3940
public function onAuthenticationFailure(Request $request, AuthenticationException $exception)
4041
{
@@ -56,7 +57,7 @@ public function supportsRememberMe()
5657
* Override to control what happens when the user hits a secure page
5758
* but isn't logged in yet.
5859
*
59-
* @return RedirectResponse
60+
* @return Response
6061
*/
6162
public function start(Request $request, AuthenticationException $authException = null)
6263
{

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.