[Validator] validate nested constraints only if they are in the same group #47211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Aug 6, 2022
| Q | A |
|---|---|
| Branch? | 5.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #46638 |
| License | MIT |
| Doc PR |
welcoMattic
approved these changes
Aug 8, 2022
ogizanagi
approved these changes
Aug 8, 2022
ogizanagi
reviewed
Aug 8, 2022
src/Symfony/Component/Validator/Constraints/AtLeastOneOfValidator.php
Outdated
Show resolved
Hide resolved
fabpot
approved these changes
Aug 9, 2022
|
Are the test broken by this PR? |
|
I'm gonna check. |
|
fabbot issue should be fixed IMO. |
I rebased, the tests were actually already fixed before by #47203 |
|
Thank you @xabbuh. |
This was referenced Aug 26, 2022
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.