Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[HttpClient] Fix response id property check in MockResponse #44428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2021
Merged

[HttpClient] Fix response id property check in MockResponse #44428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 2 src/Symfony/Component/HttpClient/Response/MockResponse.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ public static function fromRequest(string $method, string $url, array $options,
*/
protected static function schedule(self $response, array &$runningResponses): void
{
if (!$response->id) {
if (!isset($response->id)) {
throw new InvalidArgumentException('MockResponse instances must be issued by MockHttpClient before processing.');
}

Expand Down
9 changes: 9 additions & 0 deletions 9 src/Symfony/Component/HttpClient/Tests/Response/MockResponseTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
namespace Symfony\Component\HttpClient\Tests\Response;

use PHPUnit\Framework\TestCase;
use Symfony\Component\HttpClient\Exception\InvalidArgumentException;
use Symfony\Component\HttpClient\Exception\JsonException;
use Symfony\Component\HttpClient\Exception\TransportException;
use Symfony\Component\HttpClient\Response\MockResponse;
Expand Down Expand Up @@ -107,4 +108,12 @@ public function testErrorIsTakenIntoAccountInInitialization()
'error' => 'ccc error',
]))->getStatusCode();
}

public function testMustBeIssuedByMockHttpClient()
{
$this->expectException(InvalidArgumentException::class);
$this->expectExceptionMessage('MockResponse instances must be issued by MockHttpClient before processing.');

(new MockResponse())->getContent();
}
}
Morty Proxy This is a proxified and sanitized view of the page, visit original site.