Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Lock] Create tables in transaction only if supported by driver #44383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

martinssipenko
Copy link
Contributor

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

Fixed DoctrineDbalStore to allow the creation of a lock table within a transaction only if it is supported by the driver.

@martinssipenko
Copy link
Contributor Author

@jderusse I've updated code to use Platform now, but I don't quite understand why tests on 7.2 are failing.

@jderusse
Copy link
Member

jderusse commented Dec 1, 2021

I don't quite understand why tests on 7.2 are failing.

Tests are falling because the class PostgreSQLPlatform, does not exist in a version compatible with PHP 7.2. That's why getCurrentTimestampStatement used platform instead of driver.

@derrabus
Copy link
Member

derrabus commented Dec 2, 2021

Tests are falling because the class PostgreSQLPlatform, does not exist in a version compatible with PHP 7.2.

It does, but with different casing. Add this to the top of the test file, to trigger the autoloader with the old class name as well:

class_exists('Doctrine\DBAL\Platforms\PostgreSqlPlatform');

@martinssipenko
Copy link
Contributor Author

Alright, CI is finally green. @jderusse @derrabus could you take a look at it?

@martinssipenko
Copy link
Contributor Author

@jderusse @derrabus any updates on this?

@martinssipenko
Copy link
Contributor Author

@jderusse Any updates here? CI just keeps failing randomly, not sure what can/should I do about it.

@fabpot
Copy link
Member

fabpot commented Dec 20, 2021

Thank you @martinssipenko.

@fabpot fabpot force-pushed the lock-table-creation branch from 3488164 to 9395de9 Compare December 20, 2021 10:07
@fabpot fabpot merged commit 83dbb47 into symfony:5.4 Dec 20, 2021
@martinssipenko martinssipenko deleted the lock-table-creation branch December 20, 2021 10:19
This was referenced Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.