-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Lock] Create tables in transaction only if supported by driver #44383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jderusse I've updated code to use Platform now, but I don't quite understand why tests on 7.2 are failing. |
Tests are falling because the class |
It does, but with different casing. Add this to the top of the test file, to trigger the autoloader with the old class name as well: class_exists('Doctrine\DBAL\Platforms\PostgreSqlPlatform'); |
aad2242
to
5e2d494
Compare
751f0f1
to
90ddecd
Compare
31a950a
to
3488164
Compare
@jderusse Any updates here? CI just keeps failing randomly, not sure what can/should I do about it. |
Thank you @martinssipenko. |
3488164
to
9395de9
Compare
Fixed
DoctrineDbalStore
to allow the creation of a lock table within a transaction only if it is supported by the driver.