[Lock] create lock table if it does not exist #44370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please add a test? |
|
@derrabus I'd be happy to, but given this is my first contribution to Symfony and none of the other sites have tests for this case I would need some guidance. |
|
@derrabus check the last commit, perhaps that would work? If remove the |
GromNaN
approved these changes
Nov 30, 2021
derrabus
approved these changes
Nov 30, 2021
|
Thank you @martinssipenko for taking care of this regression. |
jderusse
reviewed
Nov 30, 2021
|
Exact, there was the same check for DBAL in 5.3. https://github.com/symfony/symfony/blob/5.3/src/Symfony/Component/Lock/Store/PdoStore.php#L143 It is wise to add it back. |
|
could you open a PR to handle it @martinssipenko? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug where tables are not automatically created when using
Symfony\Component\Lock\Store\DoctrineDbalStore.