[Console] Check for existence of proc_open to fix #4338 #4357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -921,6 +921,10 @@ protected function getDefaultHelperSet() | ||
| */ | ||
| private function getSttyColumns() | ||
| { | ||
| if(!function_exists('proc_open')) { |
There was a problem hiding this comment.
there is a missing space after the if keyword.
|
I forgot to ask you to sent a new PR for the 2.0 branch instead of master. Thanks. |
|
proc_open is not used in 2.0? |
|
sorry, I thought I was in the 2.0 branch locally... but it was master. Merged, thanks. |
fabpot
added a commit
that referenced
this pull request
May 21, 2012
Commits ------- 0a3dd0f [Console] Check for existence of proc_open to fix #4338 Discussion ---------- [Console] Check for existence of proc_open to fix #4338 It is quite common to disable proc_open for security purposes. This PR checks for the existence of the proc_open function and fixes Issue #4338 Replacement for PR4356 --------------------------------------------------------------------------- by travisbot at 2012-05-21T10:49:59Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1387784) (merged dd991bea into 1407f11). --------------------------------------------------------------------------- by travisbot at 2012-05-21T11:35:21Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1387991) (merged 0a3dd0f into 1407f11). --------------------------------------------------------------------------- by fabpot at 2012-05-21T12:17:32Z I forgot to ask you to sent a new PR for the 2.0 branch instead of master. Thanks. --------------------------------------------------------------------------- by davidwindell at 2012-05-21T13:03:36Z proc_open is not used in 2.0?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is quite common to disable proc_open for security purposes.
This PR checks for the existence of the proc_open function and fixes Issue #4338