Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit bde26b1

Browse filesBrowse files
committed
merged branch davidwindell/issue_4338 (PR #4357)
Commits ------- 0a3dd0f [Console] Check for existence of proc_open to fix #4338 Discussion ---------- [Console] Check for existence of proc_open to fix #4338 It is quite common to disable proc_open for security purposes. This PR checks for the existence of the proc_open function and fixes Issue #4338 Replacement for PR4356 --------------------------------------------------------------------------- by travisbot at 2012-05-21T10:49:59Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1387784) (merged dd991bea into 1407f11). --------------------------------------------------------------------------- by travisbot at 2012-05-21T11:35:21Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1387991) (merged 0a3dd0f into 1407f11). --------------------------------------------------------------------------- by fabpot at 2012-05-21T12:17:32Z I forgot to ask you to sent a new PR for the 2.0 branch instead of master. Thanks. --------------------------------------------------------------------------- by davidwindell at 2012-05-21T13:03:36Z proc_open is not used in 2.0?
2 parents d6c4356 + 0a3dd0f commit bde26b1
Copy full SHA for bde26b1

File tree

Expand file treeCollapse file tree

1 file changed

+4
-0
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+4
-0
lines changed

‎src/Symfony/Component/Console/Application.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Console/Application.php
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -921,6 +921,10 @@ protected function getDefaultHelperSet()
921921
*/
922922
private function getSttyColumns()
923923
{
924+
if (!function_exists('proc_open')) {
925+
return;
926+
}
927+
924928
$descriptorspec = array(1 => array('pipe', 'w'), 2 => array('pipe', 'w'));
925929
$process = proc_open('stty -a | grep columns', $descriptorspec, $pipes, null, null, array('suppress_errors' => true));
926930
if (is_resource($process)) {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.