Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Changed some translations to be more in line with native Serbian language #43291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2021
Merged

Changed some translations to be more in line with native Serbian language #43291

merged 1 commit into from
Oct 2, 2021

Conversation

ajakov
Copy link
Contributor

@ajakov ajakov commented Oct 2, 2021

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #41829
License MIT
Doc PR

I wanted to work on issue #41829 but could not find any actually missing translations.
But I did find some there were not in line with how Serbian language is actually used and I changed those. Hope this is fine.

@carsonbot carsonbot added this to the 4.4 milestone Oct 2, 2021
@fabpot
Copy link
Member

fabpot commented Oct 2, 2021

There is a missing translation in https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Validator/Resources/translations/validators.sr_Cyrl.xlf (the last one, id 100, which you can find here for English: https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Validator/Resources/translations/validators.en.xlf).

@ajakov
Copy link
Contributor Author

ajakov commented Oct 2, 2021

Ah, I see what happened, I did not fetch upstream ...
Thank you @fabpot, should be good now.

@fabpot
Copy link
Member

fabpot commented Oct 2, 2021

Thank you @ajakov.

@fabpot fabpot merged commit 0fd1e9e into symfony:4.4 Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.