[Notifier] Allow passing a previous throwable to exceptions #42183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander M. Turek <me@derrabus.de>
|
You beat me with a minute =) |
Nyholm
reviewed
Jul 19, 2021
There was a problem hiding this comment.
I agree to add this as a bugfix. It does not break BC: https://3v4l.org/bqFsI
| @@ -91,7 +91,7 @@ class UnsupportedSchemeException extends LogicException | ||
| /** | ||
| * @param string[] $supported | ||
| */ | ||
| public function __construct(Dsn $dsn, string $name = null, array $supported = []) | ||
| public function __construct(Dsn $dsn, string $name = null, array $supported = [], \Throwable $previous = null) |
There was a problem hiding this comment.
Do you have a use case where this is needed?
There was a problem hiding this comment.
Forbidding to chain exceptions is really a bad anti-pattern. I would simply always allow it.
There was a problem hiding this comment.
Fair.
I just dont know of a situation where you would like to chain a UnsupportedSchemeException.
OskarStark
approved these changes
Jul 19, 2021
|
Good catch, thanks Alexander. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should always be possible to pass a a previous throwable to a new exception. This PR streamlines the constructors of the Notifier component's exception classes.