[Notifier] Make sure Http TransportException is not leaking #42182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
reviewed
Jul 19, 2021
| try { | ||
| $statusCode = $response->getStatusCode(); | ||
| } catch (TransportExceptionInterface $e) { | ||
| throw new TransportException('Could not reach the remote Discord server.', $response, 0, $e); |
There was a problem hiding this comment.
Psalm is right. Let's fix that: #42183
|
The CI is a false negative. I decide to ignore fabbot here and the psalm issue is fixed in #42183 |
derrabus
approved these changes
Jul 19, 2021
This was referenced Jul 19, 2021
OskarStark
approved these changes
Jul 19, 2021
4fa06e3 to
1eed488
Compare
|
Good catch, thanks Tobias. |
OskarStark
added a commit
that referenced
this pull request
Jul 19, 2021
…leaking (Nyholm) This PR was squashed before being merged into the 5.3 branch. Discussion ---------- [Notifier] [5.3] Make sure Http TransportException is not leaking | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Same as #42182 but for bridges introduced in 5.3 Commits ------- 77b2409 [Notifier] [5.3] Make sure Http TransportException is not leaking
OskarStark
added a commit
that referenced
this pull request
Jul 19, 2021
…leaking (Nyholm) This PR was merged into the 5.4 branch. Discussion ---------- [Notifier] [5.4] Make sure Http TransportException is not leaking | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Same as #42182 but for bridges introduced in 5.4 Commits ------- a90596b [Notifier] [5.4] Make sure Http TransportException is not leaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We dont want the notifier to throw exceptions from the http-client component. This will make sure to catch such exceptions and rethrow the proper TransportException from the Notifier component.