Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Prepare PasswordUpgraderInterface implementations for 6.0 signature #42001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2021
Merged

Prepare PasswordUpgraderInterface implementations for 6.0 signature #42001

merged 1 commit into from
Jul 6, 2021

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Jul 6, 2021 •
edited
Loading

Q A
Branch? 5.3
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Makes implementations compatible with both 5.x and 6.x to make #41982 green.

@chalasr chalasr requested a review from wouterj as a code owner July 6, 2021 12:16
@chalasr chalasr mentioned this pull request Jul 6, 2021
Merged
nicolas-grekas
nicolas-grekas reviewed Jul 6, 2021
View reviewed changes
src/Symfony/Component/Security/Core/User/ChainUserProvider.php Outdated Show resolved Hide resolved
@nicolas-grekas
Copy link
Member

for 5.3?

@chalasr chalasr changed the base branch from 5.4 to 5.3 July 6, 2021 12:52
@chalasr chalasr force-pushed the prepare-upgradePassword-6 branch from da22133 to b6c4be2 Compare July 6, 2021 12:52
@chalasr chalasr force-pushed the prepare-upgradePassword-6 branch 2 times, most recently from 08c0ad5 to 6a58be9 Compare July 6, 2021 12:54
@chalasr chalasr force-pushed the prepare-upgradePassword-6 branch from 6a58be9 to 5ca9403 Compare July 6, 2021 12:55
@chalasr chalasr added this to the 5.3 milestone Jul 6, 2021
@chalasr
Copy link
Member Author

chalasr commented Jul 6, 2021

rebased

@nicolas-grekas
Copy link
Member

Thank you @chalasr.

@nicolas-grekas nicolas-grekas merged commit 03e9081 into symfony:5.3 Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
4 participants
@chalasr @nicolas-grekas @stof @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.