[Security] Remove getPassword() and getSalt() from UserInterface #41982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
8838c98 to
ed58c69
Compare
stof
reviewed
Jul 6, 2021
src/Symfony/Component/PasswordHasher/Hasher/UserPasswordHasher.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Core/Authentication/Provider/DaoAuthenticationProvider.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Core/Authentication/Provider/DaoAuthenticationProvider.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Core/Validator/Constraints/UserPasswordValidator.php
Show resolved
Hide resolved
b3d2f99 to
d2b36b6
Compare
|
|
Actually not: the Merging as is would break 5.4, that's what this tells. |
|
Thanks, on it. |
|
Should be ok with #42001. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 6, 2021
…0 signature (chalasr) This PR was merged into the 5.3 branch. Discussion ---------- Prepare PasswordUpgraderInterface implementations for 6.0 signature | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Makes implementations compatible with both 5.x and 6.x to make #41982 green. Commits ------- 5ca9403 Prepare PasswordUpgraderInterface implementations for 6.0 signatures
d2b36b6 to
1548f13
Compare
73d0dab to
9218b8a
Compare
chalasr
added a commit
that referenced
this pull request
Jul 6, 2021
… (chalasr) This PR was merged into the 5.3 branch. Discussion ---------- [Security] Make fixture compatible with both 5.x and 6.x | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Last one needed to make #41982 green hopefully. Commits ------- 0a240eb [Security] Make fixture compatible with both 5.x and 6.x
9218b8a to
4ad0376
Compare
|
Now green |
4ad0376 to
178af1f
Compare
Tobion
reviewed
Jul 7, 2021
Tobion
reviewed
Jul 7, 2021
...fony/Component/Security/Core/Tests/Authentication/Provider/DaoAuthenticationProviderTest.php
Show resolved
Hide resolved
178af1f to
6620f74
Compare
|
Comments addressed, thanks for the reviews. |
wouterj
reviewed
Jul 8, 2021
src/Symfony/Component/Security/Core/Authentication/Provider/DaoAuthenticationProvider.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Core/Authentication/Token/AbstractToken.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Http/RememberMe/TokenBasedRememberMeServices.php
Show resolved
Hide resolved
6620f74 to
d3a2865
Compare
d3a2865 to
30e2c00
Compare
wouterj
approved these changes
Jul 8, 2021
|
Thank you @chalasr. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with BC layers from #40267