Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Form, Security, Validator] Add missing Persian translations (fa_IR) #38828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2020
Merged

[Form, Security, Validator] Add missing Persian translations (fa_IR) #38828

merged 1 commit into from
Oct 26, 2020

Conversation

a-shafaat
Copy link
Contributor

[Form, Security, Validator] Add missing Persian translations, related to issue #38757

Q A
Branch? 3.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #38757
License MIT

@a-shafaat a-shafaat requested a review from xabbuh as a code owner October 26, 2020 17:03
@jderusse jderusse added this to the 3.4 milestone Oct 26, 2020
Nyholm
Nyholm reviewed Oct 26, 2020
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thank you very much.

I used Google Translate to try to verify these. My comments below might be very wrong. But can you double check?

src/Symfony/Component/Form/Resources/translations/validators.fa.xlf Outdated Show resolved Hide resolved
src/Symfony/Component/Form/Resources/translations/validators.fa.xlf Outdated Show resolved Hide resolved
src/Symfony/Component/Form/Resources/translations/validators.fa.xlf Outdated Show resolved Hide resolved
src/Symfony/Component/Form/Resources/translations/validators.fa.xlf Outdated Show resolved Hide resolved
Nyholm
Nyholm approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Great work. Im super happy with this.

Thank you

👍

@derrabus derrabus changed the title [Form, Security, Validator] Add missing Persian translations (fa_IR) #38757 [Form, Security, Validator] Add missing Persian translations (fa_IR) Oct 26, 2020
@derrabus
Copy link
Member

Thank you @Ashafaat.

@derrabus derrabus merged commit a28d0eb into symfony:3.4 Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees
No one assigned
Labels
Form Missing translations Security Status: Reviewed Validator
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
5 participants
@a-shafaat @derrabus @Nyholm @jderusse @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.