Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix redis connection error message #38359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

alexander-schranz
Copy link
Contributor

@alexander-schranz alexander-schranz commented Sep 30, 2020

Use correct instance of redis to getLastError

Q A
Branch? 4.4 (for 4.3 see #38358)
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #...
License MIT
Doc PR symfony/symfony-docs#...

Same as #38358 but handles also the dbindex error correctly.

The $redis is only set in the tests, the correct redis instance is available under $this->connection.

Reproduce: give a false AUTH to the redis:

Before:

[Error]
Call to a member function getLastError() on null

Now:

[Symfony\Component\Messenger\Exception\InvalidArgumentException]
Redis connection failed: ERR Client sent AUTH, but no password is set

In 5.x this class was moved hope git will handle it correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.