[Messenger] Fix redis connection error message #38358
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use correct instance of redis to getLastError
chalasr
approved these changes
Sep 30, 2020
nicolas-grekas
approved these changes
Sep 30, 2020
|
@nicolas-grekas oh thx then only #38359 is relevant. |
|
Thank you @alexander-schranz. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 30, 2020
…schranz) This PR was submitted for the 4.3 branch but it was merged into the 4.4 branch instead. Discussion ---------- [Messenger] Fix redis connection error message Use correct instance of redis to getLastError | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Fix #... | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> The `$redis` is only set in the tests, the correct redis instance is available under `$this->connection`. Reproduce: give a false `AUTH` to the redis: Before: > [Error] > Call to a member function getLastError() on null Now: > [Symfony\Component\Messenger\Exception\InvalidArgumentException] > Redis connection failed: ERR Client sent AUTH, but no password is set Commits ------- f4e42ad Fix redis connection error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use correct instance of redis to getLastError
The
$redisis only set in the tests, the correct redis instance is available under$this->connection.Reproduce: give a false
AUTHto the redis:Before:
Now: