[Uid] remove Uuid::getVariant()#36064
Merged
fabpot merged 1 commit intoMar 14, 2020
symfony:mastersymfony/symfony:masterfrom
nicolas-grekas:uuid-no-variantnicolas-grekas/symfony:uuid-no-variantCopy head branch name to clipboard
Merged
[Uid] remove Uuid::getVariant()#36064fabpot merged 1 commit intosymfony:mastersymfony/symfony:masterfrom nicolas-grekas:uuid-no-variantnicolas-grekas/symfony:uuid-no-variantCopy head branch name to clipboard
fabpot merged 1 commit into
symfony:mastersymfony/symfony:masterfrom
nicolas-grekas:uuid-no-variantnicolas-grekas/symfony:uuid-no-variantCopy head branch name to clipboard
Conversation
jakzal
approved these changes
Mar 13, 2020
fabpot
approved these changes
Mar 14, 2020
Member
|
Thank you @nicolas-grekas. |
nicolas-grekas
added a commit
that referenced
this pull request
Mar 14, 2020
This PR was merged into the 5.1-dev branch. Discussion ---------- [Uid] use one class per type of UUID | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - (embeds #36064 for now) Would it make sense to have one class per type of UUID? This aligns the type system and UUID types, so that one could type hint e.g. `UuidV4 $uuid`. This PR does so. `UuidV1`/2/3/4 and `NullUuid` all extend the base `Uuid` class, which provides common methods and the factories needed to create each king of UUID. This means we don't need the `getType()` nor the `isNull()` methods since they can be replaced by instanceof checks. As expected, `getTime()` and `getMac()` then now exist only on the `UuidV1` class - no need for any version check nor any `LogicException` anymore. Each type is guaranteed to contain a UUID that matches its class' type. The base `Uuid` class is used for the "no type" type. Commits ------- 62f6ac4 [Uid] use one class per type of UUID
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's simplify the API. One less concept to grasp.
I think there are no use cases for variants in modern tech, check:
https://en.wikipedia.org/wiki/Universally_unique_identifier#Variants