Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fixed invalid changelog 4.0.0 for VarDumper #33836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2019
Merged

Conversation

adrozdek
Copy link
Contributor

@adrozdek adrozdek commented Oct 3, 2019

Q A
Branch? 4.3
Bug fix? no
New feature? no
Deprecations? no
License MIT

I changed CHANGELOG.md to reflect actual changes in the code. The third argument is called $filter, not $context. This mistake was propageted to UPGRADE-4.0.md. I fixed that in #33821

I changed CHANGELOG.md to reflect actual changes in the code. The third argument is called $filter, not $context. This mistake was propageted to UPGRADE-4.0.md. I fixed that in symfony#33821
@fabpot
Copy link
Member

fabpot commented Oct 3, 2019

Thank you @adrozdek.

fabpot added a commit that referenced this pull request Oct 3, 2019
This PR was merged into the 4.3 branch.

Discussion
----------

Fixed invalid changelog 4.0.0 for VarDumper

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| License       | MIT

I changed CHANGELOG.md to reflect actual changes in the code. The third argument is called $filter, not $context. This mistake was propageted to UPGRADE-4.0.md. I fixed that in #33821

Commits
-------

169a2b3 Fixed invalid changelog 4.0.0 for VarDumper
@fabpot fabpot merged commit 169a2b3 into symfony:4.3 Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.