Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 2c2d2ac

Browse filesBrowse files
fabpotfabpot
committed
minor #33836 Fixed invalid changelog 4.0.0 for VarDumper (adrozdek)
This PR was merged into the 4.3 branch. Discussion ---------- Fixed invalid changelog 4.0.0 for VarDumper | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | License | MIT I changed CHANGELOG.md to reflect actual changes in the code. The third argument is called $filter, not $context. This mistake was propageted to UPGRADE-4.0.md. I fixed that in #33821 Commits ------- 169a2b3 Fixed invalid changelog 4.0.0 for VarDumper
2 parents abe2745 + 169a2b3 commit 2c2d2ac
Copy full SHA for 2c2d2ac

File tree

1 file changed

+2
-2
lines changed
Filter options

1 file changed

+2
-2
lines changed

‎src/Symfony/Component/VarDumper/CHANGELOG.md

Copy file name to clipboardExpand all lines: src/Symfony/Component/VarDumper/CHANGELOG.md
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,9 @@ CHANGELOG
2525
* support for passing `\ReflectionClass` instances to the `Caster::castObject()`
2626
method has been dropped, pass class names as strings instead
2727
* the `Data::getRawData()` method has been removed
28-
* the `VarDumperTestTrait::assertDumpEquals()` method expects a 3rd `$context = null`
28+
* the `VarDumperTestTrait::assertDumpEquals()` method expects a 3rd `$filter = 0`
2929
argument and moves `$message = ''` argument at 4th position.
30-
* the `VarDumperTestTrait::assertDumpMatchesFormat()` method expects a 3rd `$context = null`
30+
* the `VarDumperTestTrait::assertDumpMatchesFormat()` method expects a 3rd `$filter = 0`
3131
argument and moves `$message = ''` argument at 4th position.
3232

3333
3.4.0

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.