Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Correct PHPDoc type for float ttl #28719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2018
Merged

Correct PHPDoc type for float ttl #28719

merged 1 commit into from
Oct 6, 2018

Conversation

soullivaneuh
Copy link
Contributor

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

It can be null as the Lock instance accepts it.

It will fix that kind of PHPStan issue:

src/AppBundle/Command/AbstractCommand.php:45:Parameter #2 $ttl of method Symfony\Component\Lock\Factory::createLock() expects float, null given.

It can be null as the Lock instance accepts it.
@xabbuh xabbuh added this to the 3.4 milestone Oct 4, 2018
@xabbuh xabbuh added the Lock label Oct 4, 2018
@fabpot
Copy link
Member

fabpot commented Oct 6, 2018

Thank you @soullivaneuh.

@fabpot fabpot merged commit b662e7e into symfony:3.4 Oct 6, 2018
fabpot added a commit that referenced this pull request Oct 6, 2018
This PR was merged into the 3.4 branch.

Discussion
----------

Correct PHPDoc type for float ttl

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

It can be null as the Lock instance accepts it.

It will fix that kind of PHPStan issue:

```
src/AppBundle/Command/AbstractCommand.php:45:Parameter #2 $ttl of method Symfony\Component\Lock\Factory::createLock() expects float, null given.
```

Commits
-------

b662e7e Correct PHPDoc type for float ttl
@soullivaneuh soullivaneuh deleted the patch-1 branch April 21, 2021 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.