Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 63d287b

Browse filesBrowse files
committed
minor #28719 Correct PHPDoc type for float ttl (Soullivaneuh)
This PR was merged into the 3.4 branch. Discussion ---------- Correct PHPDoc type for float ttl | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A It can be null as the Lock instance accepts it. It will fix that kind of PHPStan issue: ``` src/AppBundle/Command/AbstractCommand.php:45:Parameter #2 $ttl of method Symfony\Component\Lock\Factory::createLock() expects float, null given. ``` Commits ------- b662e7e Correct PHPDoc type for float ttl
2 parents 155fab6 + b662e7e commit 63d287b
Copy full SHA for 63d287b

File tree

Expand file treeCollapse file tree

1 file changed

+3
-3
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+3
-3
lines changed

‎src/Symfony/Component/Lock/Factory.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Lock/Factory.php
+3-3Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,9 @@ public function __construct(StoreInterface $store)
3636
/**
3737
* Creates a lock for the given resource.
3838
*
39-
* @param string $resource The resource to lock
40-
* @param float $ttl Maximum expected lock duration in seconds
41-
* @param bool $autoRelease Whether to automatically release the lock or not when the lock instance is destroyed
39+
* @param string $resource The resource to lock
40+
* @param float|null $ttl Maximum expected lock duration in seconds
41+
* @param bool $autoRelease Whether to automatically release the lock or not when the lock instance is destroyed
4242
*
4343
* @return Lock
4444
*/

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.