Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Update css for svg files in web profiler toolbar #27959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Update css for svg files in web profiler toolbar #27959

wants to merge 4 commits into from

Conversation

yvh
Copy link
Contributor

@yvh yvh commented Jul 16, 2018

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets no
License MIT
Doc PR no

Update css for svg files in web profiler toolbar :

  • Fix vertical-align (because some reset css like Bootstrap 4.1.2 add svg:not(:root) { overflow: hidden; vertical-align: middle; }
  • Fix scaling issue in IE9, IE10 and IE11 (I know IE is bad but ... :-) )

@ro0NL
Copy link
Contributor

ro0NL commented Jul 16, 2018

already fixed by #27941 ?

@yvh
Copy link
Contributor Author

yvh commented Jul 16, 2018

I've added !important on the css rule to be sure that's not overridden.
I have also fixed the IE issue.

@ro0NL
Copy link
Contributor

ro0NL commented Jul 16, 2018 •
edited
Loading

Yeah but this PR targets a different selector; .sf-toolbarreset *, whereas the merged PR will target .sf-toolbar-block .sf-toolbar-icon svg (it's not merged up to master yet). Hence the question if it's still needed, or more specifically, see #27941 (comment)

The IE issue seems valid, not sure :) but that's the scope of this PR then... right?

@yvh
Copy link
Contributor Author

yvh commented Jul 16, 2018

Indeed !

But for me, the css rule already exist in .sf-toolbarreset * selector. It's not necessary to duplicate this rule. Just improve it.
So what can I do ? Remove my modification and let rule for IE ?

@ro0NL
Copy link
Contributor

ro0NL commented Jul 16, 2018

well.. !important has downsides too :) im fine with the applied patch. Given the baseline issue is fixed, id turn this PR into fixing the IE issue;

  • revert the baseline change (it's in 2.8 already)
  • does the IE fix apply to 2.8? If so can you switch the target branch to it
  • for visual changes a before/after screenshot would be nice :)
  • make sure you dont break chrome etc. :P

@yvh yvh changed the base branch from master to 2.8 July 17, 2018 07:41
@yvh yvh changed the base branch from 2.8 to master July 17, 2018 07:41
@yvh yvh closed this Jul 17, 2018
@yvh
Copy link
Contributor Author

yvh commented Jul 17, 2018

I have closed this PR and created a new one. #27971

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yvh @ro0NL @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.