[WebProfilerBundle] Fixed icon alignment issue using Bootstrap 4.1.2 #27941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Jul 13, 2018
|
Thank you @jmsche. |
fabpot
added a commit
that referenced
this pull request
Jul 13, 2018
…trap 4.1.2 (jmsche) This PR was merged into the 2.8 branch. Discussion ---------- [WebProfilerBundle] Fixed icon alignment issue using Bootstrap 4.1.2 | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes? | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A Hi, This PR fixes an issue introduced by Bootstrap 4.1.2: it vertically aligns SVG icons in the middle instead of letting it stay at the baseline. I'm not sure this PR is relevant but, if I'm not the only Bootstrap user, I guess it will be useful to many and it does not break anything: it enforces what should be default. [Update] Here is the related PR merged into Bootstrap that causes the issue: twbs/bootstrap#25874 [Update 2] Before the fix:  After the fix:  Commits ------- ecef6f1 [WebProfilerBundle] Fixed icon alignment issue using Bootstrap 4.1.2
stof
reviewed
Jul 13, 2018
| @@ -263,6 +263,7 @@ div.sf-toolbar .sf-toolbar-block a:hover { | ||
| border-width: 0; | ||
| position: relative; | ||
| top: 8px; | ||
| vertical-align: baseline; |
There was a problem hiding this comment.
should it actually also apply to images ?
There was a problem hiding this comment.
I guess that shouldn't be an issue as the same is already applied to .sf-toolbarreset *
There was a problem hiding this comment.
For me, the css rule already exist in .sf-toolbarreset * selector. It's not necessary to duplicate this rule. Just improve it.
Add !important and that's ok. No ?
This was referenced Jul 23, 2018
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR fixes an issue introduced by Bootstrap 4.1.2: it vertically aligns SVG icons in the middle instead of letting it stay at the baseline.
I'm not sure this PR is relevant but, if I'm not the only Bootstrap user, I guess it will be useful to many and it does not break anything: it enforces what should be default.
[Update] Here is the related PR merged into Bootstrap that causes the issue: twbs/bootstrap#25874
[Update 2] Before the fix:
After the fix: