-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Messenger] Add more tests around the AMQP transport #27206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sroze
merged 1 commit into
symfony:4.1
from
sroze:add-more-tests-around-the-amqp-transport
May 10, 2018
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 48 additions & 0 deletions
48
src/Symfony/Component/Messenger/Tests/Transport/AmqpExt/AmqpTransportFactoryTest.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the Symfony package. | ||
* | ||
* (c) Fabien Potencier <fabien@symfony.com> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Symfony\Component\Messenger\Tests\Transport\AmqpExt; | ||
|
||
use PHPUnit\Framework\TestCase; | ||
use Symfony\Component\Messenger\Transport\AmqpExt\AmqpTransport; | ||
use Symfony\Component\Messenger\Transport\AmqpExt\AmqpTransportFactory; | ||
use Symfony\Component\Messenger\Transport\AmqpExt\Connection; | ||
use Symfony\Component\Messenger\Transport\Serialization\DecoderInterface; | ||
use Symfony\Component\Messenger\Transport\Serialization\EncoderInterface; | ||
|
||
class AmqpTransportFactoryTest extends TestCase | ||
{ | ||
public function testSupportsOnlyAmqpTransports() | ||
{ | ||
$factory = new AmqpTransportFactory( | ||
$this->getMockBuilder(EncoderInterface::class)->getMock(), | ||
$this->getMockBuilder(DecoderInterface::class)->getMock(), | ||
true | ||
); | ||
|
||
$this->assertTrue($factory->supports('amqp://localhost', array())); | ||
$this->assertFalse($factory->supports('sqs://localhost', array())); | ||
$this->assertFalse($factory->supports('invalid-dsn', array())); | ||
} | ||
|
||
public function testItCreatesTheTransport() | ||
{ | ||
$factory = new AmqpTransportFactory( | ||
$encoder = $this->getMockBuilder(EncoderInterface::class)->getMock(), | ||
$decoder = $this->getMockBuilder(DecoderInterface::class)->getMock(), | ||
true | ||
); | ||
|
||
$expectedTransport = new AmqpTransport($encoder, $decoder, Connection::fromDsn('amqp://localhost', array('foo' => 'bar'), true), array('foo' => 'bar'), true); | ||
|
||
$this->assertEquals($expectedTransport, $factory->createTransport('amqp://localhost', array('foo' => 'bar'))); | ||
} | ||
} |
66 changes: 66 additions & 0 deletions
66
src/Symfony/Component/Messenger/Tests/Transport/AmqpExt/AmqpTransportTest.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the Symfony package. | ||
* | ||
* (c) Fabien Potencier <fabien@symfony.com> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Symfony\Component\Messenger\Tests\Transport\AmqpExt; | ||
|
||
use PHPUnit\Framework\TestCase; | ||
use Symfony\Component\Messenger\Tests\Fixtures\DummyMessage; | ||
use Symfony\Component\Messenger\Transport\AmqpExt\AmqpTransport; | ||
use Symfony\Component\Messenger\Transport\AmqpExt\Connection; | ||
use Symfony\Component\Messenger\Transport\Serialization\DecoderInterface; | ||
use Symfony\Component\Messenger\Transport\Serialization\EncoderInterface; | ||
use Symfony\Component\Messenger\Transport\TransportInterface; | ||
|
||
/** | ||
* @requires extension amqp | ||
*/ | ||
class AmqpTransportTest extends TestCase | ||
{ | ||
public function testItIsATransport() | ||
{ | ||
$transport = $this->getTransport(); | ||
|
||
$this->assertInstanceOf(TransportInterface::class, $transport); | ||
} | ||
|
||
public function testReceivesMessages() | ||
{ | ||
$transport = $this->getTransport( | ||
null, | ||
$decoder = $this->getMockBuilder(DecoderInterface::class)->getMock(), | ||
$connection = $this->getMockBuilder(Connection::class)->disableOriginalConstructor()->getMock() | ||
); | ||
|
||
$decodedMessage = new DummyMessage('Decoded.'); | ||
|
||
$amqpEnvelope = $this->getMockBuilder(\AMQPEnvelope::class)->getMock(); | ||
$amqpEnvelope->method('getBody')->willReturn('body'); | ||
$amqpEnvelope->method('getHeaders')->willReturn(array('my' => 'header')); | ||
|
||
$decoder->method('decode')->with(array('body' => 'body', 'headers' => array('my' => 'header')))->willReturn($decodedMessage); | ||
$connection->method('get')->willReturn($amqpEnvelope); | ||
|
||
$transport->receive(function ($message) use ($transport, $decodedMessage) { | ||
$this->assertSame($decodedMessage, $message); | ||
|
||
$transport->stop(); | ||
}); | ||
} | ||
|
||
private function getTransport(EncoderInterface $encoder = null, DecoderInterface $decoder = null, Connection $connection = null) | ||
{ | ||
$encoder = $encoder ?: $this->getMockBuilder(EncoderInterface::class)->getMock(); | ||
$decoder = $decoder ?: $this->getMockBuilder(DecoderInterface::class)->getMock(); | ||
$connection = $connection ?: $this->getMockBuilder(Connection::class)->disableOriginalConstructor()->getMock(); | ||
|
||
return new AmqpTransport($encoder, $decoder, $connection); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This removes laziness. I'd suggest to try harder keeping feature. The factory could validate the dsn itself if that's the goal here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non. The laziness is already within the
Connection
object. There is no point of making a class creation lazy 😄 (and even that is already lazy as behind service locators)