[Messenger] Add more tests around the AMQP transport #27206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
092b559 to
022c47f
Compare
022c47f to
4b8a655
Compare
yceruto
reviewed
May 8, 2018
| @@ -34,7 +34,13 @@ public function __construct(EncoderInterface $encoder, DecoderInterface $decoder | ||
|
|
||
| public function createTransport(string $dsn, array $options): TransportInterface | ||
| { | ||
| return new AmqpTransport($this->encoder, $this->decoder, $dsn, $options, $this->debug); | ||
| return new AmqpTransport( |
fabpot
reviewed
May 9, 2018
| new AmqpTransport($encoder, $decoder, Connection::fromDsn('amqp://localhost', array('foo' => 'bar'), true), array('foo' => 'bar'), true), | ||
| $transport | ||
| ); | ||
| } |
fabpot
reviewed
May 9, 2018
| $connection, | ||
| $options, | ||
| $debug | ||
| ); |
ogizanagi
reviewed
May 9, 2018
| @@ -22,18 +22,17 @@ class AmqpTransport implements TransportInterface | ||
| { | ||
| private $encoder; | ||
| private $decoder; | ||
| private $dsn; | ||
| private $connection; | ||
| private $options; |
There was a problem hiding this comment.
$options and $debug are not used anymore
4b8a655 to
1c0bb0e
Compare
|
@fabpot @yceruto @ogizanagi good catches, updated. |
sroze
commented
May 9, 2018
| use Symfony\Component\Messenger\Transport\Serialization\EncoderInterface; | ||
| use Symfony\Component\Messenger\Transport\TransportInterface; | ||
|
|
||
| class AmqpTransportTest extends TestCase |
There was a problem hiding this comment.
Should requires amqp extension
1c0bb0e to
faf9382
Compare
ogizanagi
approved these changes
May 9, 2018
| $this->dsn = $dsn; | ||
| $this->options = $options; | ||
| $this->debug = $debug; | ||
| $this->connection = $connection; |
There was a problem hiding this comment.
This removes laziness. I'd suggest to try harder keeping feature. The factory could validate the dsn itself if that's the goal here?
There was a problem hiding this comment.
Non. The laziness is already within the Connection object. There is no point of making a class creation lazy 😄 (and even that is already lazy as behind service locators)
sroze
added a commit
that referenced
this pull request
May 10, 2018
…oze) This PR was merged into the 4.1 branch. Discussion ---------- [Messenger] Add more tests around the AMQP transport | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ø | License | MIT | Doc PR | ø Adding more tests to the AMQP transport/factory. These should have captured the following 3 bugs: #27198, #27197, #27196. Commits ------- faf9382 Add more tests around the AMQP transport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding more tests to the AMQP transport/factory. These should have captured the following 3 bugs: #27198, #27197, #27196.