Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Messenger] Fix missing s/tolerate_no_handler/allow_no_handler/g #27176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2018
Merged

[Messenger] Fix missing s/tolerate_no_handler/allow_no_handler/g #27176

merged 1 commit into from
May 7, 2018

Conversation

ogizanagi
Copy link
Contributor

@ogizanagi ogizanagi commented May 7, 2018

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

Spotted while rebasing #27128: some places weren't updated. Most are in tests and not that much important but should be updated for consistency. But moreover, the AllowNoHandlerMiddleware wiring in DI was still referencing the old class name.

@fabpot
Copy link
Member

fabpot commented May 7, 2018

Thank you @ogizanagi.

@fabpot fabpot merged commit e7cfb59 into symfony:master May 7, 2018
fabpot added a commit that referenced this pull request May 7, 2018
…dler/g (ogizanagi)

This PR was merged into the 4.1-dev branch.

Discussion
----------

[Messenger] Fix missing s/tolerate_no_handler/allow_no_handler/g

| Q             | A
| ------------- | ---
| Branch?       | master <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | N/A   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

Spotted while rebasing #26945: some places weren't updated. Most are in tests and not that much important but should be updated for consistency. But moreover, the `AllowNoHandlerMiddleware` wiring in DI was still referencing the old class name.

Commits
-------

e7cfb59 [Messenger] Fix missing s/tolerate_no_handler/allow_no_handler/g
@ogizanagi ogizanagi deleted the fix/messenger/miss_tolerate_no_handler_replace branch May 7, 2018 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.