Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 2efb474

Browse filesBrowse files
fabpotfabpot
committed
bug #27176 [Messenger] Fix missing s/tolerate_no_handler/allow_no_handler/g (ogizanagi)
This PR was merged into the 4.1-dev branch. Discussion ---------- [Messenger] Fix missing s/tolerate_no_handler/allow_no_handler/g | Q | A | ------------- | --- | Branch? | master <!-- see below --> | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Spotted while rebasing #26945: some places weren't updated. Most are in tests and not that much important but should be updated for consistency. But moreover, the `AllowNoHandlerMiddleware` wiring in DI was still referencing the old class name. Commits ------- e7cfb59 [Messenger] Fix missing s/tolerate_no_handler/allow_no_handler/g
2 parents df02969 + e7cfb59 commit 2efb474
Copy full SHA for 2efb474

File tree

5 files changed

+9
-9
lines changed
Filter options

5 files changed

+9
-9
lines changed

‎src/Symfony/Bundle/FrameworkBundle/Resources/config/messenger.xml

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Resources/config/messenger.xml
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
</service>
3030

3131
<!-- Middlewares -->
32-
<service id="messenger.middleware.tolerate_no_handler" class="Symfony\Component\Messenger\Middleware\TolerateNoHandler" abstract="true" />
32+
<service id="messenger.middleware.allow_no_handler" class="Symfony\Component\Messenger\Middleware\AllowNoHandlerMiddleware" abstract="true" />
3333
<service id="messenger.middleware.call_message_handler" class="Symfony\Component\Messenger\Middleware\HandleMessageMiddleware" abstract="true">
3434
<argument type="service" id="messenger.handler_resolver" />
3535
</service>

‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/php/messenger_multiple_buses.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/php/messenger_multiple_buses.php
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,14 @@
77
'messenger.bus.commands' => null,
88
'messenger.bus.events' => array(
99
'middlewares' => array(
10-
'tolerate_no_handler',
10+
'allow_no_handler',
1111
),
1212
),
1313
'messenger.bus.queries' => array(
1414
'default_middlewares' => false,
1515
'middlewares' => array(
1616
'route_messages',
17-
'tolerate_no_handler',
17+
'allow_no_handler',
1818
'call_message_handler',
1919
),
2020
),

‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/xml/messenger_multiple_buses.xml

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/xml/messenger_multiple_buses.xml
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,11 @@
99
<framework:messenger default-bus="messenger.bus.commands">
1010
<framework:bus name="messenger.bus.commands" />
1111
<framework:bus name="messenger.bus.events">
12-
<framework:middleware>tolerate_no_handler</framework:middleware>
12+
<framework:middleware>allow_no_handler</framework:middleware>
1313
</framework:bus>
1414
<framework:bus name="messenger.bus.queries" default-middlewares="false">
1515
<framework:middleware>route_messages</framework:middleware>
16-
<framework:middleware>tolerate_no_handler</framework:middleware>
16+
<framework:middleware>allow_no_handler</framework:middleware>
1717
<framework:middleware>call_message_handler</framework:middleware>
1818
</framework:bus>
1919
</framework:messenger>

‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/yml/messenger_multiple_buses.yml

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/yml/messenger_multiple_buses.yml
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@ framework:
55
messenger.bus.commands: ~
66
messenger.bus.events:
77
middlewares:
8-
- "tolerate_no_handler"
8+
- "allow_no_handler"
99
messenger.bus.queries:
1010
default_middlewares: false
1111
middlewares:
1212
- "route_messages"
13-
- "tolerate_no_handler"
13+
- "allow_no_handler"
1414
- "call_message_handler"

‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -614,10 +614,10 @@ public function testMessengerWithMultipleBuses()
614614
$this->assertEquals(array('logging', 'route_messages', 'call_message_handler'), $container->getParameter('messenger.bus.commands.middlewares'));
615615
$this->assertTrue($container->has('messenger.bus.events'));
616616
$this->assertSame(array(), $container->getDefinition('messenger.bus.events')->getArgument(0));
617-
$this->assertEquals(array('logging', 'tolerate_no_handler', 'route_messages', 'call_message_handler'), $container->getParameter('messenger.bus.events.middlewares'));
617+
$this->assertEquals(array('logging', 'allow_no_handler', 'route_messages', 'call_message_handler'), $container->getParameter('messenger.bus.events.middlewares'));
618618
$this->assertTrue($container->has('messenger.bus.queries'));
619619
$this->assertSame(array(), $container->getDefinition('messenger.bus.queries')->getArgument(0));
620-
$this->assertEquals(array('route_messages', 'tolerate_no_handler', 'call_message_handler'), $container->getParameter('messenger.bus.queries.middlewares'));
620+
$this->assertEquals(array('route_messages', 'allow_no_handler', 'call_message_handler'), $container->getParameter('messenger.bus.queries.middlewares'));
621621

622622
$this->assertTrue($container->hasAlias('message_bus'));
623623
$this->assertSame('messenger.bus.commands', (string) $container->getAlias('message_bus'));

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.