[HttpFoundation] Added "null" type on Request::create docblock #25878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keradus
commented
Jan 21, 2018
| @@ -130,7 +130,7 @@ class Request | ||
| public $headers; | ||
|
|
||
| /** | ||
| * @var string|resource | ||
| * @var null|string|resource |
There was a problem hiding this comment.
actually, this could also be false, as we have false === $this->content several times
There was a problem hiding this comment.
at 1st glance i was wondering why it's false-able when it's already null-able...
looks like way too many types are allowed
| * @param array $cookies The COOKIE parameters | ||
| * @param array $files The FILES parameters | ||
| * @param array $server The SERVER parameters | ||
| * @param null|string|resource $content The raw body data |
There was a problem hiding this comment.
please put null last, it's the less useful type to tell about (personally I don't even get its value at all: it's already on the signature, but anyway...)
There was a problem hiding this comment.
arrays are also in the signatures you know ;)
nicolas-grekas
approved these changes
Jan 29, 2018
|
Thank you @keradus. |
fabpot
added a commit
that referenced
this pull request
Jan 29, 2018
…cblock (keradus) This PR was squashed before being merged into the 2.7 branch (closes #25878). Discussion ---------- [HttpFoundation] Added "null" type on Request::create docblock | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | n/a | Fixed tickets | n/a | License | MIT | Doc PR | n/a Continuation of #24902 and #25875 Commits ------- b18f9e7 [HttpFoundation] Added "null" type on Request::create docblock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #24902 and #25875