Added null type on Request::create docblock #24902
Conversation
| * @param array $cookies The request cookies ($_COOKIE) | ||
| * @param array $files The request files ($_FILES) | ||
| * @param array $server The server parameters ($_SERVER) | ||
| * @param string|null $content The raw body data |
There was a problem hiding this comment.
it affects not only this method, but other methods and property as well
There was a problem hiding this comment.
@keradus what do you mean? Looking at the code, passing null is not supported for the other argument. Yes, technically you can, but then, the behavior is certainly not part of any contract - except for $content.
There was a problem hiding this comment.
Oups, I needed to post to actually understand your comment. Other methods :)
@plazma0 would you mind reviewing the $content argument then in other methods?
Please note that this PR should be merged against branch 2.7, so that if you know how to do it (moving the target branch + rebasing your branch), you're welcomed.
|
@plazma0 Still interested in finishing this pull request? |
…e docblock (Jack Wright) This PR was merged into the 2.7 branch. Discussion ---------- [HttpFoundation] Added "resource" type on Request::create docblock | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Replaces #24902 Commits ------- d1a96ca [HttpFoundation] Added "resource" type on Request::create docblock
…cblock (keradus) This PR was squashed before being merged into the 2.7 branch (closes #25878). Discussion ---------- [HttpFoundation] Added "null" type on Request::create docblock | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | n/a | Fixed tickets | n/a | License | MIT | Doc PR | n/a Continuation of #24902 and #25875 Commits ------- b18f9e7 [HttpFoundation] Added "null" type on Request::create docblock
Uh oh!
There was an error while loading. Please reload this page.