-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Remove Exclusive Lock That Breaks NFS Caching #25337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This removes the exclusive lock that was introduced in symfony#24960. NFS File Systems do not support exclusive locking, and generates a lot of errors every time you try to do anything with che cache.
Do we use |
@stof Good question. Let me do a search on the codebase. I'll get back with you in a moment. |
It appears it's used in several other places: Symfony\Component\Filesystem\LockHandler::lock (100) There are also a few in non-Symfony components that are tied closely to Symfony: Honestly, I've never run into issues with these and I don't think any of these locks are new, so I don't know that they are that big of a deal. It looks to me that the vast majority of these check to make sure we can get a lock with I'm open to opinions. Like I said, I've never had any issues with the rest of these. |
Well, place implementing a lock indeed must use LOCK_EX. So this list looks fine to me. |
@stof my thought exactly. Let me know if you need anything else from me. |
Thank you @brianfreytag. |
This PR was merged into the 3.4 branch. Discussion ---------- Remove Exclusive Lock That Breaks NFS Caching | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25336 | License | MIT | Doc PR | n/a #24960 introduced an issue with NFS mounts that do not support exclusive locks. This reverts that change. FYI @kalessil Commits ------- a7ac100 Remove LOCK_EX That Breaks Cache Usage on NFS
Not to be pushy, but is there a timetable for a 3.4.2 release? |
#24960 introduced an issue with NFS mounts that do not support exclusive locks. This reverts that change.
FYI @kalessil