SCA with Php Inspections (EA Extended) #24960
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kalessil
commented
Nov 13, 2017
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
- Greedy regex characters set fixed
- Potential race-conditions fixed
| @@ -102,7 +102,7 @@ public function warmUp(array $values) | ||
|
|
||
| $tmpFile = uniqid($this->file, true); | ||
|
|
||
| file_put_contents($tmpFile, $dump); | ||
| file_put_contents($tmpFile, $dump, LOCK_EX); |
There was a problem hiding this comment.
This one is wrong: the file has a random name exactly to prevent the need for a lock.
There was a problem hiding this comment.
Oh, new false-positive. I'll revert this one.
|
BTW @nicolas-grekas, probably the modified code should rely on atomic writes (like FS component do, it's the right way to go IMO) and not exclusive lock as per mine changes. |
|
@kalessil I don't think adding a new dependency on FS is needed:
|
|
@stof: for sure, new dependency is not needed =) That's not so bad idea to not touch deprecated code - ths =) Will revert. |
|
I did revert changes in deprecated/dev-tools code. |
nicolas-grekas
approved these changes
Dec 4, 2017
|
Thank you @kalessil. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 4, 2017
This PR was squashed before being merged into the 3.4 branch (closes #24960). Discussion ---------- SCA with Php Inspections (EA Extended) | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a - Greedy regex characters set fixed - Potential race-conditions fixed Commits ------- 4d39a2d SCA with Php Inspections (EA Extended)
|
Thank you for merging @nicolas-grekas =) |
brianfreytag
added a commit
to brianfreytag/symfony
that referenced
this pull request
Dec 5, 2017
PR symfony#24960 introduced an issue with nfs mounts. nfs mounts do not, by default, support exclusive locks. Fixes Issue symfony#25336
brianfreytag
added a commit
to brianfreytag/symfony
that referenced
this pull request
Dec 5, 2017
This removes the exclusive lock that was introduced in symfony#24960. NFS File Systems do not support exclusive locking, and generates a lot of errors every time you try to do anything with che cache.
nicolas-grekas
added a commit
that referenced
this pull request
Dec 6, 2017
This PR was merged into the 3.4 branch. Discussion ---------- Remove Exclusive Lock That Breaks NFS Caching | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25336 | License | MIT | Doc PR | n/a #24960 introduced an issue with NFS mounts that do not support exclusive locks. This reverts that change. FYI @kalessil Commits ------- a7ac100 Remove LOCK_EX That Breaks Cache Usage on NFS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.