Ran fabbot

symfony · alexbowers · Jul 28, 2017 · Jul 28, 2017 · Jul 28, 2017 · Jul 28, 2017
commit f46239db35080cabfd187b946a96eae1cc1423e3
diff --git a/src/Symfony/Component/Process/Process.php b/src/Symfony/Component/Process/Process.php
@@ -839,7 +839,7 @@ public function isRunning()
     */
    public function isStarted()
    {
-        return $this->status != self::STATUS_READY;
+        return self::STATUS_READY != $this->status;
    }

    /**
@@ -851,7 +851,7 @@ public function isTerminated()
    {
        $this->updateStatus(false);

-        return $this->status == self::STATUS_TERMINATED;
+        return self::STATUS_TERMINATED == $this->status;
    }

    /**
@@ -1330,7 +1330,7 @@ public function areEnvironmentVariablesInherited()
     */
    public function checkTimeout()
    {
-        if ($this->status !== self::STATUS_STARTED) {
+        if (self::STATUS_STARTED !== $this->status) {
            return;
        }

@@ -1521,7 +1521,7 @@ private function readPipes($blocking, $close)
        $callback = $this->callback;
        foreach ($result as $type => $data) {
            if (3 !== $type) {
-                $callback($type === self::STDOUT ? self::OUT : self::ERR, $data);
+                $callback(self::STDOUT === $type ? self::OUT : self::ERR, $data);
            } elseif (!isset($this->fallbackStatus['signaled'])) {
                $this->fallbackStatus['exitcode'] = (int) $data;
            }

diff --git a/src/Symfony/Component/Process/Tests/ProcessTest.php b/src/Symfony/Component/Process/Tests/ProcessTest.php
@@ -80,7 +80,7 @@ public function testInvalidCwdOnWindows()
            // Check that it works fine if the CWD exists
            $cmd = new Process('echo test', __DIR__);
            $cmd->run();
-        } catch(\Exception $e) {
+        } catch (\Exception $e) {
            $this->fail($e);
        }

@@ -353,7 +353,7 @@ public function testCallbackIsExecutedForOutput()

        $called = false;
        $p->run(function ($type, $buffer) use (&$called) {
-            $called = $buffer === 'foo';
+            $called = 'foo' === $buffer;
        });

        $this->assertTrue($called, 'The callback should be executed with the output');
@@ -366,7 +366,7 @@ public function testCallbackIsExecutedForOutputWheneverOutputIsDisabled()

        $called = false;
        $p->run(function ($type, $buffer) use (&$called) {
-            $called = $buffer === 'foo';
+            $called = 'foo' === $buffer;
        });

        $this->assertTrue($called, 'The callback should be executed with the output');