-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Added deprecation to cwd not existing Fixes #18249 #23708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
a019543
Added deprecation to cwd not existing
alexbowers 602a7d4
Upgrade Docs updated
alexbowers 7103381
Fixed codestyle issues
alexbowers 56a4a01
Renamed test
alexbowers f9225dd
Improved tests to check for deprecation properly
alexbowers 4c9f3d0
Check if cwd is a directory, not a file
alexbowers f44bfd9
Remove unnecessary comment
alexbowers 296cfe6
Improved documenting the deprecation
alexbowers 5918f16
Improve error and make test pass again
alexbowers 1dd14be
Use options properly
alexbowers 06dd2eb
Run the commands without checking exit codes
alexbowers d684e70
Improve testing
alexbowers 7e0141c
Forgot to put semi colon on
alexbowers 1e4abf6
Fix test
alexbowers 53b2c2e
Fixing coding style
alexbowers 8830131
Windows exception
alexbowers d9746a2
Removed newline
alexbowers babbfea
Changed the upgrade doc wording
alexbowers d57ac4d
Codestyle fix
alexbowers b93e7ad
Fixes
alexbowers e8a2702
Behaviour -> behavior
alexbowers 647fdff
New line
alexbowers 29ad993
Handle test that should pass, failing, better
alexbowers 8e9ddd2
Improvement fixes
alexbowers f46239d
Ran fabbot
alexbowers File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
New line
- Loading branch information
commit 647fdffc40cb3fe5da78150331c4e678ee4c9e9d
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing blank line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.