Disable inlining deprecated services #23540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
approved these changes
Jul 16, 2017
| if ($definition->isDeprecated()) { | ||
| return false; | ||
| } | ||
|
|
||
| if ($definition->isPublic() || $definition->isLazy()) { |
There was a problem hiding this comment.
Why not add || isDeprecated() here?
nicolas-grekas
approved these changes
Jul 17, 2017
fabpot
requested changes
Jul 17, 2017
| @@ -891,6 +891,25 @@ public function testAutowiring() | ||
|
|
||
| $this->assertEquals('a', (string) $container->getDefinition('b')->getArgument(0)); | ||
| } | ||
|
|
||
| /** | ||
| * @group legacy |
There was a problem hiding this comment.
As this test and the other one should not be removed in 4.0, I suggest to add a comment to make it clear.
Taluu
approved these changes
Jul 17, 2017
|
Thank you @alekitto. |
fabpot
added a commit
that referenced
this pull request
Jul 17, 2017
This PR was merged into the 2.8 branch. Discussion ---------- Disable inlining deprecated services | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23536 | License | MIT Deprecation errors are not triggered for inlined services. Disabling inlining for those services will fix this issue. Commits ------- 6ab8ca0 disable inlining deprecated services
This was referenced Jul 17, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecation errors are not triggered for inlined services.
Disabling inlining for those services will fix this issue.