[2.8] [DoctrineBridge] fix tests added in EntityType with FQCN #17699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HeahDude
commented
Feb 5, 2016
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | needs #17694 |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
- Wait for [2.7] [DoctrineBridge] [Form] fix choice_value in EntityType #17694 to be merged in 2.8
| @@ -36,6 +36,7 @@ | ||
|
|
||
| class EntityTypeTest extends TypeTestCase | ||
| { | ||
| const ENTITY_TYPE_CLASS = 'Symfony\Bridge\Doctrine\Form\Type\EntityType'; |
There was a problem hiding this comment.
👎 for this change, it will complicate merges and is a personal preference "enhancement"
There was a problem hiding this comment.
@nicolas-grekas I agree for the "enhancement" as it considerably eases reading when reviewing and allows autocompletion when writing new tests.
IMHO this should be done in other form tests class too as of 2.8 in a dedicated PR.
This one is originally made to replace alias by fqcn for tests added in #17694.
|
So this requires #17694 to be merged first? |
|
@xabbuh yes it does |
d57c947 to
6b07594
Compare
|
#17694 is merged in 2.8 now |
6b07594 to
beb70d9
Compare
|
ping @fabpot, waiting for the green lights, but it should be ok :) |
|
Green ! |
|
Thank you @HeahDude. |
fabpot
added a commit
that referenced
this pull request
Feb 15, 2016
…h FQCN (HeahDude) This PR was merged into the 2.8 branch. Discussion ---------- [2.8] [DoctrineBridge] fix tests added in EntityType with FQCN | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | needs #17694 | Fixed tickets | - | License | MIT | Doc PR | - - [x] Wait for #17694 to be merged in 2.8 Commits ------- beb70d9 fix FQCN in tests added by #17694
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.