[2.7] [DoctrineBridge] [Form] fix choice_value in EntityType #17694

HeahDude · Feb 4, 2016

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#17693, #17271, #13964
License	MIT
Doc PR	symfony/symfony-docs#6260

HeahDude · Feb 4, 2016

Before :

Time: 10.1 seconds, Memory: 65.50Mb

There was 1 failure:

1) Symfony\Bridge\Doctrine\Tests\Form\Type\EntityTypeTest::testOverrideChoicesValues
Field should be synchronized.
Failed asserting that false is true.

/Users/Heah/Sites/dev/symfony/src/Symfony/Bridge/Doctrine/Tests/Form/Type/EntityTypeTest.php:761

FAILURES!
Tests: 431, Assertions: 625, Failures: 1, Skipped: 11.

Legacy deprecation notices (212)
KO ./src/Symfony/Bridge/Doctrine

After :

Time: 8.92 seconds, Memory: 65.25Mb

OK, but incomplete, skipped, or risky tests!
Tests: 431, Assertions: 627, Skipped: 11.

Legacy deprecation notices (212)
OK ./src/Symfony/Bridge/Doctrine

nicolas-grekas · Feb 4, 2016

Please revert the indentation changes...

HeahDude · Feb 4, 2016

@nicolas-grekas oupssss

HeahDude · Feb 4, 2016

Done
Status: Needs Review

webmozart · Feb 5, 2016

Thanks for that PR! Looks good to me.

Status: reviewed

HeahDude · Feb 5, 2016

thanks @webmozart, just added #13964 as fixed though.

HeahDude · Feb 5, 2016

@fabpot @webmozart. Tests in 2.8 need renaming entity to Symfony\Bridge\Doctrine\Form\Type\EntityType, should I make a PR on 2.8 to update only this once 2.7 is merged in 2.8 or do another version of this one right now for the greater branches ?

Also I suggest to use a constant for the fqnc of EntityType in EntityTypeTest as for the fixtures.

webmozart · Feb 5, 2016

@HeahDude I would create a separate PR and rebase this one once that is merged.

HeahDude · Feb 11, 2016

Updated description with link to the doc PR and tests are ready for 2.8 with #17699.

ping @symfony/deciders

and add some tests

…oice_attr` to `EntityType` (HeahDude) This PR was merged into the 2.7 branch. Discussion ---------- add missing options `choice_value`, `choice_name` and `choice_attr` to `EntityType` | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no (& yes symfony/symfony#17694) | Applies to | 2.7+ | Fixed tickets | #6259 Commits ------- 9785f08 add missing options `choice_value`, `choice_name` and `choice_attr` to `EntityType`

xabbuh · Feb 15, 2016

👍

fabpot · Feb 15, 2016

Thank you @HeahDude.

…pe (HeahDude) This PR was merged into the 2.7 branch. Discussion ---------- [2.7] [DoctrineBridge] [Form] fix choice_value in EntityType | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17693, #17271, #13964 | License | MIT | Doc PR | symfony/symfony-docs#6260 Commits ------- 2336d5c fix choice_value option in EntityType and add some tests

HeahDude · Feb 15, 2016

thanks @fabpot, don't forget to ping me in #17699 for the rebase, when this one gets merged in 2.8 :)

…h FQCN (HeahDude) This PR was merged into the 2.8 branch. Discussion ---------- [2.8] [DoctrineBridge] fix tests added in EntityType with FQCN | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | needs #17694 | Fixed tickets | - | License | MIT | Doc PR | - - [x] Wait for #17694 to be merged in 2.8 Commits ------- beb70d9 fix FQCN in tests added by #17694

* 2.8: [DependencyInjection] fix dumped YAML snytax Remove InputOption::VALUE_REQUIRED mode from $default parameter description as InputOption::setDefault() throws an exception only when called in InputOption::VALUE_NONE mode. In practice the $default value could still be accessed in InputOption::VALUE_REQUIRED mode in case InputOption was never set but accessed from InputDefinition::getOption() method [Form] Fixed violation mapping if multiple forms are using the same (or part of the same) property path fix FQCN in tests added by #17694 Fix locale and written standard inconsistencies for Norwegian translations [Form] [Validator] Fix locale inconsistencies in Norwegian translations [TwigBridge] Symfony 3.1 forward compatibility fixed CS [DependencyInjection] fixed exceptions thrown by get method of ContainerBuilder [Yaml] properly parse lists in object maps [FrameworkBundle] Remove unused private method. [Form] remove useless code in ResizeFormListener [Config] Fix EnumNodeDefinition to allow building enum nodes with one element fix choice_value option in EntityType and add some tests

* 3.0: [DependencyInjection] fix dumped YAML snytax Remove InputOption::VALUE_REQUIRED mode from $default parameter description as InputOption::setDefault() throws an exception only when called in InputOption::VALUE_NONE mode. In practice the $default value could still be accessed in InputOption::VALUE_REQUIRED mode in case InputOption was never set but accessed from InputDefinition::getOption() method [Yaml] always restore the error handler in tests [FrameworkBundle] fix YAML syntax fix YAML syntax in functional tests config [HttpFoundation] [Session] Removed unnecessary PHP version check as minimum requirement is now 5.5.9 [Form] Fixed violation mapping if multiple forms are using the same (or part of the same) property path fix FQCN in tests added by #17694 Fix locale and written standard inconsistencies for Norwegian translations [Form] [Validator] Fix locale inconsistencies in Norwegian translations [TwigBridge] Symfony 3.1 forward compatibility fixed CS [DependencyInjection] fixed exceptions thrown by get method of ContainerBuilder [Yaml] properly parse lists in object maps [FrameworkBundle] Remove unused private method. [Form] remove useless code in ResizeFormListener [Config] Fix EnumNodeDefinition to allow building enum nodes with one element [Form] remove deprecated empty_value_in_choices fix choice_value option in EntityType and add some tests

carsonbot added the Status: Needs Review label Feb 4, 2016

HeahDude mentioned this pull request Feb 4, 2016

[Form] Add option "widget" to ChoiceType #6602

Closed

carsonbot added Status: Reviewed and removed Status: Needs Review labels Feb 5, 2016

HeahDude mentioned this pull request Feb 5, 2016

[Proposal] Exception 'Entities passed to the choice field must be managed.' - Code works just fine without this being thrown maybe have switch to bypass #13964

Closed

HeahDude changed the title ~~[2.7] [Form] fix choice_value in EntityType~~ [2.7] [DoctrineBridge] [Form] fix choice_value in EntityType Feb 5, 2016

fix choice_value option in EntityType

2336d5c

and add some tests

HeahDude force-pushed the fix-#17693 branch from 32eed3c to 2336d5c Compare February 11, 2016 01:16

HeahDude mentioned this pull request Feb 11, 2016

[WIP] [2.8] [Form] fix FQCN in tests added by #17760 #17759

Merged

2 tasks

HeahDude mentioned this pull request Feb 14, 2016

[Form][2.8] Type "entity" not setting selected data when choice_value is a string attribute #17271

Closed

fabpot merged commit 2336d5c into symfony:2.7 Feb 15, 2016

HeahDude deleted the fix-#17693 branch February 15, 2016 08:18

HeahDude added a commit to HeahDude/symfony that referenced this pull request Feb 15, 2016

fix FQCN in tests added by symfony#17694

beb70d9

This was referenced Feb 28, 2016

Release v2.7.10 #17951

Merged

Release v2.8.3 #17952

Merged

Release v3.0.3 #17953

Merged

HeahDude mentioned this pull request Mar 30, 2016

[Form] [DoctrineBridge] optimized LazyChoiceList and DoctrineChoiceLoader #18359

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[2.7] [DoctrineBridge] [Form] fix choice_value in EntityType #17694

[2.7] [DoctrineBridge] [Form] fix choice_value in EntityType #17694

Uh oh!

HeahDude commented Feb 4, 2016

Uh oh!

HeahDude commented Feb 4, 2016

Uh oh!

nicolas-grekas commented Feb 4, 2016

Uh oh!

HeahDude commented Feb 4, 2016

Uh oh!

HeahDude commented Feb 4, 2016

Uh oh!

webmozart commented Feb 5, 2016

Uh oh!

HeahDude commented Feb 5, 2016

Uh oh!

HeahDude commented Feb 5, 2016

Uh oh!

webmozart commented Feb 5, 2016

Uh oh!

HeahDude commented Feb 11, 2016

Uh oh!

xabbuh commented Feb 15, 2016

Uh oh!

fabpot commented Feb 15, 2016

Uh oh!

HeahDude commented Feb 15, 2016

Uh oh!

Uh oh!

Search code, repositories, users, issues, pull requests...

Uh oh!

[2.7] [DoctrineBridge] [Form] fix choice_value in EntityType #17694

[2.7] [DoctrineBridge] [Form] fix choice_value in EntityType #17694

Uh oh!

Conversation

HeahDude commented Feb 4, 2016

Uh oh!

HeahDude commented Feb 4, 2016

Uh oh!

nicolas-grekas commented Feb 4, 2016

Uh oh!

HeahDude commented Feb 4, 2016

Uh oh!

HeahDude commented Feb 4, 2016

Uh oh!

webmozart commented Feb 5, 2016

Uh oh!

HeahDude commented Feb 5, 2016

Uh oh!

HeahDude commented Feb 5, 2016

Uh oh!

webmozart commented Feb 5, 2016

Uh oh!

HeahDude commented Feb 11, 2016

Uh oh!

xabbuh commented Feb 15, 2016

Uh oh!

fabpot commented Feb 15, 2016

Uh oh!

HeahDude commented Feb 15, 2016

Uh oh!

Uh oh!