[DependencyInjection] resolve circular reference #14446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue has been fixed in symfony#11422. Due to a bad merge in 3bed1b7 it partially appeared again in Symfony 2.6 or higher.
|
👍 |
1 similar comment
|
👍 |
|
The |
|
@xabbuh Have a look at https://github.com/symfony/symfony/pull/14445/files to see which changes to the tests are necessary. |
|
@hacfi any reason to keep a blank line between |
|
@xabbuh 👍 |
|
@dosten Nope :)..just didn’t think about that. |
|
👍 |
|
Thank you @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 27, 2015
This PR was merged into the 2.6 branch. Discussion ---------- [DependencyInjection] resolve circular reference | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #11422, #14445 | License | MIT | Doc PR | This issue has been fixed in #11422. Due to a bad merge in 3bed1b7 it partially appeared again in Symfony 2.6 or higher. Commits ------- 8b3b3ce [DependencyInjection] resolve circular reference
nicolas-grekas
added a commit
that referenced
this pull request
Apr 27, 2015
This PR was merged into the 2.3 branch. Discussion ---------- [DependencyInjection] Fixed missing tests | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Follow up of #11422 and #14446 Commits ------- 2892902 Fixed tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue has been fixed in #11422. Due to a bad merge in 3bed1b7 it partially appeared again in Symfony 2.6 or higher.