[DependencyInjection] Fix self-referenced 'service_container' service #14445
Conversation
… to allow garbage collection Follow up of symfony#11422
|
@fabpot #11422 was merged into 2.3 but didn’t make it into the next versions..see: 3bed1b7 is the erroneous commit/merge. |
|
it is weird if it is not in newer versions. this looks like a bad conflict resolution. The proper fix would be to reapply the bugfix in 2.6. And I don't think the new constant is worth it |
|
It seems that it's only the constructor that wasn't merged properly. The rest seems to be present (see for example https://github.com/symfony/symfony/blob/2.6/src/Symfony/Component/DependencyInjection/Container.php#L200-205). |
|
This is going to be changed in #14155 |
|
The issue was the conflict resolution in 3bed1b7 |
|
@xabbuh Exactly..see 3bed1b7#diff-8 |
|
@hacfi reapplying the bugfix must be done first, before doing anything for 3.0 (because the reapplied bugfix will then also reach the master branch) |
|
@dosten My bad..closing then. |
|
see #14446 |
This PR was merged into the 2.6 branch. Discussion ---------- [DependencyInjection] resolve circular reference | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #11422, #14445 | License | MIT | Doc PR | This issue has been fixed in #11422. Due to a bad merge in 3bed1b7 it partially appeared again in Symfony 2.6 or higher. Commits ------- 8b3b3ce [DependencyInjection] resolve circular reference
..to allow garbage collection.
Follow up of #11422
I created the constant
Symfony\Component\DependencyInjection\ContainerInterface::CONTAINER_IDwhile I was at it and removed an unused use statement in a test. Let me know if I should remove the constant again or create a separate PR.