Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit c3a030c

Browse filesBrowse files
nicolas-grekasnicolas-grekas
committed
feature #64094 [Messenger] Deprecate StopWorkerOnTimeLimitListener in favor of time_limit worker option (Toflar)
This PR was merged into the 8.1 branch. Discussion ---------- [Messenger] Deprecate `StopWorkerOnTimeLimitListener` in favor of time_limit worker option | Q | A | ------------- | --- | Branch? | 8.1 | Bug fix? | no | New feature? | no | Deprecations? | yes | Issues | | License | MIT This deprecates the `StopWorkerOnTimeLimitListener` as discussed in #64086. Commits ------- 4686954 [Messenger] Deprecate StopWorkerOnTimeLimitListener in favor of time_limit worker option
2 parents 692ecef + 4686954 commit c3a030c
Copy full SHA for c3a030c

5 files changed

+14-1Lines changed: 14 additions & 1 deletion

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎UPGRADE-8.1.md‎

Copy file name to clipboardExpand all lines: UPGRADE-8.1.md
+1Lines changed: 1 addition & 0 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,7 @@ Messenger
109109
* Receivers no longer delete messages from the queue on decode failure;
110110
they are routed through the normal retry/failure transport path instead
111111
* Add argument `$fetchSize` to `ReceiverInterface::get()` and `QueueReceiverInterface::getFromQueues()`
112+
* Deprecate `StopWorkerOnTimeLimitListener` in favor of using the `time_limit` worker option
112113

113114
Security
114115
--------
Collapse file

‎src/Symfony/Component/Messenger/CHANGELOG.md‎

Copy file name to clipboardExpand all lines: src/Symfony/Component/Messenger/CHANGELOG.md
+1Lines changed: 1 addition & 0 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ CHANGELOG
1414
* Allow configuring the service reset interval in the `messenger:consume` command via the `--no-reset` option
1515
* Add `AmqpPriorityStamp` to set per-message priority on the AMQP transport
1616
* Add `ReleaseDeduplicationLockOnFailureListener` that releases the deduplication lock when a message fails and will not be retried
17+
* Deprecate `StopWorkerOnTimeLimitListener` in favor of the `time_limit` worker option
1718

1819
8.0
1920
---
Collapse file

‎src/Symfony/Component/Messenger/EventListener/StopWorkerOnTimeLimitListener.php‎

Copy file name to clipboardExpand all lines: src/Symfony/Component/Messenger/EventListener/StopWorkerOnTimeLimitListener.php
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,13 @@
1717
use Symfony\Component\Messenger\Event\WorkerStartedEvent;
1818
use Symfony\Component\Messenger\Exception\InvalidArgumentException;
1919

20+
trigger_deprecation('symfony/messenger', '8.1', '"%s" is deprecated, use the "time_limit" worker option instead.', StopWorkerOnTimeLimitListener::class);
21+
2022
/**
2123
* @author Simon Delicata <simon.delicata@free.fr>
2224
* @author Tobias Schultze <http://tobion.de>
25+
*
26+
* @deprecated since Symfony 8.1, use the "time_limit" worker option instead
2327
*/
2428
class StopWorkerOnTimeLimitListener implements EventSubscriberInterface
2529
{
Collapse file

‎src/Symfony/Component/Messenger/Tests/EventListener/StopWorkerOnTimeLimitListenerTest.php‎

Copy file name to clipboardExpand all lines: src/Symfony/Component/Messenger/Tests/EventListener/StopWorkerOnTimeLimitListenerTest.php
+6Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,21 @@
1414
use PHPUnit\Framework\Attributes\Group;
1515
use PHPUnit\Framework\TestCase;
1616
use Psr\Log\LoggerInterface;
17+
use Symfony\Bridge\PhpUnit\ExpectDeprecationTrait;
1718
use Symfony\Component\Messenger\Event\WorkerRunningEvent;
1819
use Symfony\Component\Messenger\EventListener\StopWorkerOnTimeLimitListener;
1920
use Symfony\Component\Messenger\Worker;
2021

2122
class StopWorkerOnTimeLimitListenerTest extends TestCase
2223
{
24+
use ExpectDeprecationTrait;
25+
2326
#[Group('time-sensitive')]
27+
#[Group('legacy')]
2428
public function testWorkerStopsWhenTimeLimitIsReached()
2529
{
30+
$this->expectDeprecation('Since symfony/messenger 8.1: "Symfony\Component\Messenger\EventListener\StopWorkerOnTimeLimitListener" is deprecated, use the "time_limit" worker option instead.');
31+
2632
$logger = $this->createMock(LoggerInterface::class);
2733
$logger->expects($this->once())->method('info')
2834
->with('Worker stopped due to time limit of {timeLimit}s exceeded', ['timeLimit' => 1]);
Collapse file

‎src/Symfony/Component/Messenger/composer.json‎

Copy file name to clipboardExpand all lines: src/Symfony/Component/Messenger/composer.json
+2-1Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@
1818
"require": {
1919
"php": ">=8.4.1",
2020
"psr/log": "^1|^2|^3",
21-
"symfony/clock": "^7.4|^8.0"
21+
"symfony/clock": "^7.4|^8.0",
22+
"symfony/deprecation-contracts": "^2.5|^3"
2223
},
2324
"require-dev": {
2425
"psr/cache": "^1.0|^2.0|^3.0",

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.