Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 5ef60f1

Browse filesBrowse files
committed
[Translation] [Loader] Add INI_SCANNER_RAW to parse ini files
| Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | yes | Deprecations? | no | Tests pass? | no | Fixed tickets | | License | MIT | Doc PR | INI_SCANNER_RAW change the default scanner mode of parse_ini_files to parse all values without evaluate. This allow values with single quotes, "no" and "false" and raise an error if you use the deprecated "#" as comment character. This change is specially good for shared translations, because a translator haven't to know that he can't use a few restricted terms. And has a residual improvement: it's twice fast that use the default value (INI_SCANNER_NORMAL) in my tests
1 parent d61f492 commit 5ef60f1
Copy full SHA for 5ef60f1

File tree

Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed

‎src/Symfony/Component/Translation/Loader/IniFileLoader.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Translation/Loader/IniFileLoader.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public function load($resource, $locale, $domain = 'messages')
3535
throw new NotFoundResourceException(sprintf('File "%s" not found.', $resource));
3636
}
3737

38-
$messages = parse_ini_file($resource, true);
38+
$messages = parse_ini_file($resource, true, INI_SCANNER_RAW);
3939

4040
$catalogue = parent::load($messages, $locale, $domain);
4141
$catalogue->addResource(new FileResource($resource));

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.