Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 52be4e5

Browse filesBrowse files
HypeMCnicolas-grekas
authored andcommitted
[HttpKernel][Workflow] Declare arguments explicitly
1 parent 3f7170f commit 52be4e5
Copy full SHA for 52be4e5

5 files changed

+9-13Lines changed: 9 additions & 13 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎UPGRADE-8.0.md‎

Copy file name to clipboardExpand all lines: UPGRADE-8.0.md
+2Lines changed: 2 additions & 0 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -234,6 +234,7 @@ HttpKernel
234234
* Remove `Kernel::getAnnotatedClassesToCompile()` and `Kernel::setAnnotatedClassCache()`
235235
* Make `ServicesResetter` class `final`
236236
* Add argument `$logChannel` to `ErrorListener::logException()`
237+
* Add argument `$event` to `DumpListener::configure()`
237238
* Replace `__sleep/wakeup()` by `__(un)serialize()` on kernels and data collectors
238239

239240
Intl
@@ -778,6 +779,7 @@ Workflow
778779

779780
* Add method `getEnabledTransition()` to `WorkflowInterface`
780781
* Add `$nbToken` argument to `Marking::mark()` and `Marking::unmark()`
782+
* Add `$asArc` argument to `Transition::getFroms()` and `Transition::getTos()`
781783
* Remove `Event::getWorkflow()` method
782784

783785
*Before*
Collapse file

‎src/Symfony/Component/HttpKernel/CHANGELOG.md‎

Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpKernel/CHANGELOG.md
+1Lines changed: 1 addition & 0 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ CHANGELOG
99
* Remove `Kernel::getAnnotatedClassesToCompile()` and `Kernel::setAnnotatedClassCache()`
1010
* Make `ServicesResetter` class `final`
1111
* Add argument `$logChannel` to `ErrorListener::logException()`
12+
* Add argument `$event` to `DumpListener::configure()`
1213
* Replace `__sleep/wakeup()` by `__(un)serialize()` on kernels and data collectors
1314

1415
7.4
Collapse file

‎src/Symfony/Component/HttpKernel/EventListener/DumpListener.php‎

Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpKernel/EventListener/DumpListener.php
+1-5Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,8 @@ public function __construct(
3838
) {
3939
}
4040

41-
/**
42-
* @param ?ConsoleCommandEvent $event
43-
*/
44-
public function configure(/* ?ConsoleCommandEvent $event = null */): void
41+
public function configure(?ConsoleCommandEvent $event = null): void
4542
{
46-
$event = 1 <= \func_num_args() ? func_get_arg(0) : null;
4743
$input = $event?->getInput();
4844

4945
$cloner = $this->cloner;
Collapse file

‎src/Symfony/Component/Workflow/CHANGELOG.md‎

Copy file name to clipboardExpand all lines: src/Symfony/Component/Workflow/CHANGELOG.md
+1Lines changed: 1 addition & 0 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ CHANGELOG
66

77
* Add method `getEnabledTransition()` to `WorkflowInterface`
88
* Add `$nbToken` argument to `Marking::mark()` and `Marking::unmark()`
9+
* Add `$asArc` argument to `Transition::getFroms()` and `Transition::getTos()`
910
* Remove `Event::getWorkflow()` method
1011

1112
*Before*
Collapse file

‎src/Symfony/Component/Workflow/Transition.php‎

Copy file name to clipboardExpand all lines: src/Symfony/Component/Workflow/Transition.php
+4-8Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -46,27 +46,23 @@ public function getName(): string
4646
}
4747

4848
/**
49-
* @param bool $asArc
50-
*
5149
* @return $asArc is true ? array<Arc> : array<string>
5250
*/
53-
public function getFroms(/* bool $asArc = false */): array
51+
public function getFroms(bool $asArc = false): array
5452
{
55-
if (1 <= \func_num_args() && func_get_arg(0)) {
53+
if ($asArc) {
5654
return $this->fromArcs;
5755
}
5856

5957
return array_column($this->fromArcs, 'place');
6058
}
6159

6260
/**
63-
* @param bool $asArc
64-
*
6561
* @return $asArc is true ? array<Arc> : array<string>
6662
*/
67-
public function getTos(/* bool $asArc = false */): array
63+
public function getTos(bool $asArc = false): array
6864
{
69-
if (1 <= \func_num_args() && func_get_arg(0)) {
65+
if ($asArc) {
7066
return $this->toArcs;
7167
}
7268

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.