Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 3779f3f

Browse filesBrowse files
GuillaumeVerdonnicolas-grekas
authored andcommitted
[Process] Non ASCII characters disappearing during the escapeshellarg
1 parent 3ee1aa0 commit 3779f3f
Copy full SHA for 3779f3f

File tree

2 files changed

+2
-1
lines changed
Filter options

2 files changed

+2
-1
lines changed

‎src/Symfony/Component/Process/ProcessUtils.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Process/ProcessUtils.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ public static function escapeArgument($argument)
7171
return $escapedArgument;
7272
}
7373

74-
return escapeshellarg($argument);
74+
return "'".str_replace("'", "'\\''", $argument)."'";
7575
}
7676

7777
/**

‎src/Symfony/Component/Process/Tests/ProcessUtilsTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Process/Tests/ProcessUtilsTest.php
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ public function dataArguments()
4343
array("'<|>\" \"'\\''f'", '<|>" "\'f'),
4444
array("''", ''),
4545
array("'with\\trailingbs\\'", 'with\trailingbs\\'),
46+
array("'withNonAsciiAccentLikeéÉèÈàÀöä'", 'withNonAsciiAccentLikeéÉèÈàÀöä'),
4647
);
4748
}
4849
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.