Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 3ee1aa0

Browse filesBrowse files
nicolas-grekasnicolas-grekas
committed
minor #21501 [FrameworkBundle][Console] JsonDescriptor: Respect original output (ogizanagi)
This PR was merged into the 2.7 branch. Discussion ---------- [FrameworkBundle][Console] JsonDescriptor: Respect original output | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | N/A | License | MIT | Doc PR | N/A I'm suggesting this one, because I recently pushed some changes to the descriptors, and of course, I'm not editing expected output fixtures by hand, but by dumping the real output to fixture files. But it's tiring to get false positive diffs when reviewing it. Descriptor tests already are painful enough 😅 This PR respects the way elements are actually output. If it's ok to you, I'll submit some other PRs to upper branches, because there are more issues regarding this (items order for instance). If it causes too much troubles getting this in sync with upper branches, let's close this and never talk about it anymore 😄 Commits ------- 08dd70b [FrameworkBundle][Console] JsonDescriptor: Respect original output
2 parents b182088 + 08dd70b commit 3ee1aa0
Copy full SHA for 3ee1aa0

File tree

7 files changed

+10
-30
lines changed
Filter options

7 files changed

+10
-30
lines changed

‎src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Descriptor/builder_1_public.json

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Descriptor/builder_1_public.json
+1-3Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,7 @@
1111
"file": null,
1212
"factory_class": "Full\\Qualified\\FactoryClass",
1313
"factory_method": "get",
14-
"tags": [
15-
16-
]
14+
"tags": []
1715
}
1816
},
1917
"aliases": {

‎src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Descriptor/builder_1_services.json

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Descriptor/builder_1_services.json
+2-6Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,7 @@
1111
"file": null,
1212
"factory_class": "Full\\Qualified\\FactoryClass",
1313
"factory_method": "get",
14-
"tags": [
15-
16-
]
14+
"tags": []
1715
},
1816
"definition_2": {
1917
"class": "Full\\Qualified\\Class2",
@@ -42,9 +40,7 @@
4240
},
4341
{
4442
"name": "tag2",
45-
"parameters": [
46-
47-
]
43+
"parameters": []
4844
}
4945
]
5046
}

‎src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Descriptor/builder_1_tag1.json

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Descriptor/builder_1_tag1.json
+3-9Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,17 +27,11 @@
2727
},
2828
{
2929
"name": "tag2",
30-
"parameters": [
31-
32-
]
30+
"parameters": []
3331
}
3432
]
3533
}
3634
},
37-
"aliases": [
38-
39-
],
40-
"services": [
41-
42-
]
35+
"aliases": [],
36+
"services": []
4337
}

‎src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Descriptor/definition_1.json

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Descriptor/definition_1.json
+1-3Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,5 @@
99
"file": null,
1010
"factory_class": "Full\\Qualified\\FactoryClass",
1111
"factory_method": "get",
12-
"tags": [
13-
14-
]
12+
"tags": []
1513
}

‎src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Descriptor/definition_2.json

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Descriptor/definition_2.json
+1-3Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,7 @@
2525
},
2626
{
2727
"name": "tag2",
28-
"parameters": [
29-
30-
]
28+
"parameters": []
3129
}
3230
]
3331
}

‎src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Descriptor/route_2.json

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Descriptor/route_2.json
+1-3Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,7 @@
66
"scheme": "http|https",
77
"method": "PUT|POST",
88
"class": "Symfony\\Component\\Routing\\Route",
9-
"defaults": [
10-
11-
],
9+
"defaults": [],
1210
"requirements": "NO CUSTOM",
1311
"options": {
1412
"compiler_class": "Symfony\\Component\\Routing\\RouteCompiler",

‎src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Descriptor/route_collection_1.json

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Descriptor/route_collection_1.json
+1-3Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,7 @@
2727
"scheme": "http|https",
2828
"method": "PUT|POST",
2929
"class": "Symfony\\Component\\Routing\\Route",
30-
"defaults": [
31-
32-
],
30+
"defaults": [],
3331
"requirements": "NO CUSTOM",
3432
"options": {
3533
"compiler_class": "Symfony\\Component\\Routing\\RouteCompiler",

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.