Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Update toolchain version, script, and README.md#96

Merged
MaxDesiatov merged 5 commits into
mainswiftwasm/JavaScriptKit:mainfrom
toolchain-script-readmeswiftwasm/JavaScriptKit:toolchain-script-readmeCopy head branch name to clipboard
Oct 21, 2020
Merged

Update toolchain version, script, and README.md#96
MaxDesiatov merged 5 commits into
mainswiftwasm/JavaScriptKit:mainfrom
toolchain-script-readmeswiftwasm/JavaScriptKit:toolchain-script-readmeCopy head branch name to clipboard

Conversation

@MaxDesiatov

@MaxDesiatov MaxDesiatov commented Oct 7, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

The toolchain snapshot suggested in README.md is outdated. I think we should recommend using the script to install it automatically.

Resolves #95.

@MaxDesiatov MaxDesiatov added the documentation Improvements or additions to documentation label Oct 7, 2020
@MaxDesiatov

MaxDesiatov commented Oct 7, 2020

Copy link
Copy Markdown
Member Author

Another option would be to suggest carton as the default build tool for end users. WDYT?

@github-actions

github-actions Bot commented Oct 7, 2020 •
edited
Loading

Copy link
Copy Markdown

Time Change: -96.5ms (1%)

Total Time: 8,702.5ms

ℹ️ View Unchanged
Test name Duration Change
Serialization/Write JavaScript number directly 157ms -0.25ms
Serialization/Write JavaScript string directly 159.5ms -4.5ms (2%)
Serialization/Swift Int to JavaScript 2,879.25ms +11.5ms (0%)
Serialization/Swift String to JavaScript 2,882.25ms -46.75ms (1%)
Object heap/Increment and decrement RC 2,624.5ms -56.5ms (2%)

performance-action

@carson-katri

carson-katri commented Oct 7, 2020

Copy link
Copy Markdown
Member

I suppose both could be mentioned, then they can choose what fits their needs best?

@kateinoigakukun

kateinoigakukun commented Oct 15, 2020

Copy link
Copy Markdown
Member

I think we need to provide two section, the first is for users of JavaScriptKit and the second is for contributors of JavaScriptKit.
IMO, we should keep swiftenv installation section for users of JSKit. But the installation script section is helpful for new contributors.

@MaxDesiatov MaxDesiatov changed the title Mention the install-toolchain.sh script in README.md Update toolchain version, script, and README.md Oct 19, 2020
@MaxDesiatov MaxDesiatov requested a review from a team October 19, 2020 16:47
@MaxDesiatov

MaxDesiatov commented Oct 19, 2020

Copy link
Copy Markdown
Member Author

That's updated, README.md now lists steps for newcomers that allow them to use carton, but keeps a separate section for advanced use cases and local development.

@MaxDesiatov MaxDesiatov force-pushed the toolchain-script-readme branch from c413132 to 045f5d1 Compare October 19, 2020 16:51
@MaxDesiatov MaxDesiatov force-pushed the toolchain-script-readme branch from 045f5d1 to fb798a5 Compare October 19, 2020 16:55
kateinoigakukun
kateinoigakukun reviewed Oct 20, 2020
View reviewed changes
Comment thread scripts/install-toolchain.sh Outdated
Darwin)
toolchain_download="$swift_tag-osx.tar.gz"
toolchain_download="$swift_tag-macos-x86_64.tar.gz"
echo '-macos' >> .swift-version

@kateinoigakukun kateinoigakukun Oct 20, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this line?

@MaxDesiatov MaxDesiatov Oct 20, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still waiting for the new 5.3 toolchain to be tagged tonight that fixes this.

@MaxDesiatov MaxDesiatov Oct 21, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's cleaned up now, ready for review.

@MaxDesiatov MaxDesiatov force-pushed the toolchain-script-readme branch from f823585 to e14ee9d Compare October 21, 2020 09:07
kateinoigakukun
kateinoigakukun reviewed Oct 21, 2020
View reviewed changes
Comment thread README.md Outdated
```sh
$ ./scripts/install-toolchain.sh
$ swift --version
Swift version 5.3-dev (LLVM 09686f232a, Swift 5a196c7f13)

@kateinoigakukun kateinoigakukun Oct 21, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think vendor name can be updated 👍

@kateinoigakukun kateinoigakukun Oct 21, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that swiftwasm/swift#1921 is not included in 5.3 branch 😢 But now, it's ok without SwiftWasm vendor name...

@MaxDesiatov MaxDesiatov merged commit 766d2e1 into main Oct 21, 2020
@MaxDesiatov MaxDesiatov deleted the toolchain-script-readme branch October 21, 2020 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kateinoigakukun kateinoigakukun kateinoigakukun approved these changes

@carson-katri carson-katri carson-katri approved these changes

@j-f1 j-f1 Awaiting requested review from j-f1

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Errors building example: undefined symbols

3 participants

@MaxDesiatov @carson-katri @kateinoigakukun
Morty Proxy This is a proxified and sanitized view of the page, visit original site.