Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Rename JSValueConvertible/Constructible/Codable#88

Merged
j-f1 merged 4 commits into
mainswiftwasm/JavaScriptKit:mainfrom
rename-jsvalue-wrapper-protocolsswiftwasm/JavaScriptKit:rename-jsvalue-wrapper-protocolsCopy head branch name to clipboard
Oct 2, 2020
Merged

Rename JSValueConvertible/Constructible/Codable#88
j-f1 merged 4 commits into
mainswiftwasm/JavaScriptKit:mainfrom
rename-jsvalue-wrapper-protocolsswiftwasm/JavaScriptKit:rename-jsvalue-wrapper-protocolsCopy head branch name to clipboard

Conversation

@j-f1

@j-f1 j-f1 commented Oct 1, 2020

Copy link
Copy Markdown
Member

Fixes #87.

@j-f1 j-f1 added the enhancement New feature or request label Oct 1, 2020
@j-f1 j-f1 mentioned this pull request Oct 1, 2020
Closed
@github-actions

github-actions Bot commented Oct 1, 2020 •
edited
Loading

Copy link
Copy Markdown

Time Change: +960.75ms (6%) 🔍

Total Time: 14,198ms

Test name Duration Change
Serialization/Swift Int to JavaScript 5,045ms +258.5ms (5%) 🔍
Serialization/Swift String to JavaScript 5,451.5ms +465.25ms (8%) 🔍
Object heap/Increment and decrement RC 3,346.25ms +238.5ms (7%) 🔍
ℹ️ View Unchanged
Test name Duration Change
Serialization/Write JavaScript number directly 172.25ms -5ms (2%)
Serialization/Write JavaScript string directly 183ms +3.5ms (1%)

performance-action

MaxDesiatov
MaxDesiatov reviewed Oct 1, 2020
View reviewed changes
Comment thread Sources/JavaScriptKit/ConvertibleToJSValue.swift Outdated
MaxDesiatov
MaxDesiatov approved these changes Oct 1, 2020
View reviewed changes

@MaxDesiatov MaxDesiatov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@j-f1 j-f1 requested a review from kateinoigakukun October 1, 2020 17:21
@j-f1 j-f1 changed the title JSValueConstructible → ConvertibleToJSValue & JSValueConvertible → ConstructibleFromJSValue Rename JSValueConvertible/Constructible/Codable Oct 2, 2020
@j-f1 j-f1 merged commit bbc49d3 into main Oct 2, 2020
@j-f1 j-f1 deleted the rename-jsvalue-wrapper-protocols branch October 2, 2020 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

@kateinoigakukun kateinoigakukun kateinoigakukun approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rename JSValueConstructible and JSValueConvertible

3 participants

@j-f1 @MaxDesiatov @kateinoigakukun
Morty Proxy This is a proxified and sanitized view of the page, visit original site.